Skip to content

Commit da196bd

Browse files
committed
removes the specific upsert query which is available on PSQL 9.5 only
… in favor of the generic way fixes #15613 properly and overrides #16461 Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
1 parent 4986241 commit da196bd

File tree

2 files changed

+2
-14
lines changed

2 files changed

+2
-14
lines changed

lib/private/DB/AdapterPgSql.php

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -36,16 +36,4 @@ public function fixupStatement($statement) {
3636
return $statement;
3737
}
3838

39-
/**
40-
* @suppress SqlInjectionChecker
41-
*/
42-
public function insertIgnoreConflict(string $table,array $values) : int {
43-
$builder = $this->conn->getQueryBuilder();
44-
$builder->insert($table);
45-
foreach($values as $key => $value) {
46-
$builder->setValue($key, $builder->createNamedParameter($value));
47-
}
48-
$queryString = $builder->getSQL() . ' ON CONFLICT DO NOTHING';
49-
return $this->conn->executeUpdate($queryString, $builder->getParameters(), $builder->getParameterTypes());
50-
}
5139
}

lib/private/legacy/util.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -978,9 +978,9 @@ public static function checkDatabaseVersion() {
978978
$data = $result->fetchRow();
979979
if (isset($data['server_version'])) {
980980
$version = $data['server_version'];
981-
if (version_compare($version, '9.5.0', '<')) {
981+
if (version_compare($version, '9.0.0', '<')) {
982982
$errors[] = array(
983-
'error' => $l->t('PostgreSQL >= 9.5 required'),
983+
'error' => $l->t('PostgreSQL >= 9 required'),
984984
'hint' => $l->t('Please upgrade your database version')
985985
);
986986
}

0 commit comments

Comments
 (0)