fix(files_versions): has-preview must be either true or false

susnux · susnux · commit c0e1d493074e · 2025-08-07T12:25:20.000+02:00
Signed-off-by: Ferdinand Thiessen &lt;opensource@fthiessen.de&gt;
diff --git a/apps/files_versions/lib/Sabre/Plugin.php b/apps/files_versions/lib/Sabre/Plugin.php
@@ -78,7 +78,10 @@ public function propFind(PropFind $propFind, INode $node): void {
 		if ($node instanceof VersionFile) {
 			$propFind->handle(self::VERSION_LABEL, fn () => $node->getMetadataValue('label'));
 			$propFind->handle(self::VERSION_AUTHOR, fn () => $node->getMetadataValue('author'));
-			$propFind->handle(FilesPlugin::HAS_PREVIEW_PROPERTYNAME, fn () => $this->previewManager->isMimeSupported($node->getContentType()));
+			$propFind->handle(
+				FilesPlugin::HAS_PREVIEW_PROPERTYNAME,
+				fn (): string => $this->previewManager->isMimeSupported($node->getContentType()) ? 'true' : 'false',
+			);
 		}
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -78,7 +78,10 @@ public function propFind(PropFind $propFind, INode $node): void {`
`78`	`78`	`if ($node instanceof VersionFile) {`
`79`	`79`	`$propFind->handle(self::VERSION_LABEL, fn () => $node->getMetadataValue('label'));`
`80`	`80`	`$propFind->handle(self::VERSION_AUTHOR, fn () => $node->getMetadataValue('author'));`
`81`		`- $propFind->handle(FilesPlugin::HAS_PREVIEW_PROPERTYNAME, fn () => $this->previewManager->isMimeSupported($node->getContentType()));`
	`81`	`+ $propFind->handle(`
	`82`	`+ FilesPlugin::HAS_PREVIEW_PROPERTYNAME,`
	`83`	`+ fn (): string => $this->previewManager->isMimeSupported($node->getContentType()) ? 'true' : 'false',`
	`84`	`+ );`
`82`	`85`	`}`
`83`	`86`	`}`
`84`	`87`