Merge pull request #29420 from nextcloud/backport/29400/stable21

blizzz · web-flow · commit b8ab9ffc1e3c · 2021-10-24T01:27:20.000+02:00
[stable21] fixes an undefined index when getAccessList returns an empty array
diff --git a/apps/workflowengine/lib/Entity/File.php b/apps/workflowengine/lib/Entity/File.php
@@ -140,7 +140,7 @@ public function isLegitimatedForUserId(string $uid): bool {
 				return true;
 			}
 			$acl = $this->shareManager->getAccessList($node, true, true);
-			return array_key_exists($uid, $acl['users']);
+			return isset($acl['users']) && array_key_exists($uid, $acl['users']);
 		} catch (NotFoundException $e) {
 			return false;
 		}

Original file line number	Diff line number	Diff line change
`@@ -140,7 +140,7 @@ public function isLegitimatedForUserId(string $uid): bool {`
`140`	`140`	`return true;`
`141`	`141`	`}`
`142`	`142`	`$acl = $this->shareManager->getAccessList($node, true, true);`
`143`		`- return array_key_exists($uid, $acl['users']);`
	`143`	`+ return isset($acl['users']) && array_key_exists($uid, $acl['users']);`
`144`	`144`	`} catch (NotFoundException $e) {`
`145`	`145`	`return false;`
`146`	`146`	`}`