feat(http client): expose default request timeout constant to be used…

… instead of magic number 30 Will be used to set default where we are able to override the default timeout. See #48418 Signed-off-by: Thomas Citharel <tcit@tcit.fr>
nextcloud · Oct 10, 2024 · b42bca1 · b42bca1
1 parent d537050
commit b42bca1
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/lib/private/Http/Client/Client.php b/lib/private/Http/Client/Client.php
@@ -53,7 +53,7 @@ private function buildRequestOptions(array $options): array {
 
 		$defaults = [
 			RequestOptions::VERIFY => $this->getCertBundle(),
-			RequestOptions::TIMEOUT => 30,
+			RequestOptions::TIMEOUT => IClient::DEFAULT_REQUEST_TIMEOUT,
 		];
 
 		$options['nextcloud']['allow_local_address'] = $this->isLocalAddressAllowed($options);

diff --git a/lib/public/Http/Client/IClient.php b/lib/public/Http/Client/IClient.php
@@ -14,6 +14,14 @@
  * @since 8.1.0
  */
 interface IClient {
+
+	/**
+	 * Default request timeout for requests
+	 *
+	 * @since 31.0.0
+	 */
+	public const DEFAULT_REQUEST_TIMEOUT = 30;
+
 	/**
 	 * Sends a GET request
 	 * @param string $uri