From 9ea3f2983f410c6b036aa96349e1b1a9dd6881fd Mon Sep 17 00:00:00 2001 From: european Date: Thu, 12 Nov 2020 13:29:14 +0100 Subject: [PATCH] fix #3903: job to cleanup unneeded remote storages Add a background job for cleanup of unneeded remote storages. Signed-off-by: european --- apps/files_sharing/appinfo/info.xml | 3 +- .../composer/composer/autoload_classmap.php | 1 + .../composer/composer/autoload_static.php | 5 +- .../CleanupRemoteStoragesJob.php | 67 +++++++++++++++++++ 4 files changed, 73 insertions(+), 3 deletions(-) create mode 100644 apps/files_sharing/lib/BackgroundJob/CleanupRemoteStoragesJob.php diff --git a/apps/files_sharing/appinfo/info.xml b/apps/files_sharing/appinfo/info.xml index 3b375bbf87aa0..aea1aa556fb34 100644 --- a/apps/files_sharing/appinfo/info.xml +++ b/apps/files_sharing/appinfo/info.xml @@ -9,7 +9,7 @@ Turning the feature off removes shared files and folders on the server for all share recipients, and also on the sync clients and mobile apps. More information is available in the Nextcloud Documentation. - 1.18.0 + 1.18.1 agpl Michael Gapczynski Bjoern Schiessle @@ -29,6 +29,7 @@ Turning the feature off removes shared files and folders on the server for all s OCA\Files_Sharing\DeleteOrphanedSharesJob OCA\Files_Sharing\ExpireSharesJob OCA\Files_Sharing\BackgroundJob\FederatedSharesDiscoverJob + OCA\Files_Sharing\BackgroundJob\CleanupRemoteStoragesJob diff --git a/apps/files_sharing/composer/composer/autoload_classmap.php b/apps/files_sharing/composer/composer/autoload_classmap.php index e4a493cadfb04..c529ef6e2ca07 100644 --- a/apps/files_sharing/composer/composer/autoload_classmap.php +++ b/apps/files_sharing/composer/composer/autoload_classmap.php @@ -20,6 +20,7 @@ 'OCA\\Files_Sharing\\Activity\\Settings\\Shared' => $baseDir . '/../lib/Activity/Settings/Shared.php', 'OCA\\Files_Sharing\\AppInfo\\Application' => $baseDir . '/../lib/AppInfo/Application.php', 'OCA\\Files_Sharing\\BackgroundJob\\FederatedSharesDiscoverJob' => $baseDir . '/../lib/BackgroundJob/FederatedSharesDiscoverJob.php', + 'OCA\\Files_Sharing\\BackgroundJob\\CleanupRemoteStoragesJob' => $baseDir . '/../lib/BackgroundJob/CleanupRemoteStoragesJob.php', 'OCA\\Files_Sharing\\Cache' => $baseDir . '/../lib/Cache.php', 'OCA\\Files_Sharing\\Capabilities' => $baseDir . '/../lib/Capabilities.php', 'OCA\\Files_Sharing\\Collaboration\\ShareRecipientSorter' => $baseDir . '/../lib/Collaboration/ShareRecipientSorter.php', diff --git a/apps/files_sharing/composer/composer/autoload_static.php b/apps/files_sharing/composer/composer/autoload_static.php index 3c92a46fc82fb..3c5c692eab82c 100644 --- a/apps/files_sharing/composer/composer/autoload_static.php +++ b/apps/files_sharing/composer/composer/autoload_static.php @@ -7,14 +7,14 @@ class ComposerStaticInitFiles_Sharing { public static $prefixLengthsPsr4 = array ( - 'O' => + 'O' => array ( 'OCA\\Files_Sharing\\' => 18, ), ); public static $prefixDirsPsr4 = array ( - 'OCA\\Files_Sharing\\' => + 'OCA\\Files_Sharing\\' => array ( 0 => __DIR__ . '/..' . '/../lib', ), @@ -35,6 +35,7 @@ class ComposerStaticInitFiles_Sharing 'OCA\\Files_Sharing\\Activity\\Settings\\Shared' => __DIR__ . '/..' . '/../lib/Activity/Settings/Shared.php', 'OCA\\Files_Sharing\\AppInfo\\Application' => __DIR__ . '/..' . '/../lib/AppInfo/Application.php', 'OCA\\Files_Sharing\\BackgroundJob\\FederatedSharesDiscoverJob' => __DIR__ . '/..' . '/../lib/BackgroundJob/FederatedSharesDiscoverJob.php', + 'OCA\\Files_Sharing\\BackgroundJob\\CleanupRemoteStoragesJob' => __DIR__ . '/..' . '/../lib/BackgroundJob/CleanupRemoteStoragesJob.php', 'OCA\\Files_Sharing\\Cache' => __DIR__ . '/..' . '/../lib/Cache.php', 'OCA\\Files_Sharing\\Capabilities' => __DIR__ . '/..' . '/../lib/Capabilities.php', 'OCA\\Files_Sharing\\Collaboration\\ShareRecipientSorter' => __DIR__ . '/..' . '/../lib/Collaboration/ShareRecipientSorter.php', diff --git a/apps/files_sharing/lib/BackgroundJob/CleanupRemoteStoragesJob.php b/apps/files_sharing/lib/BackgroundJob/CleanupRemoteStoragesJob.php new file mode 100644 index 0000000000000..f16c00dfe55bb --- /dev/null +++ b/apps/files_sharing/lib/BackgroundJob/CleanupRemoteStoragesJob.php @@ -0,0 +1,67 @@ + + * + * @license GNU AGPL version 3 or any later version + * + * This program is free software: you can redistribute it and/or modify + * it under the terms of the GNU Affero General Public License as + * published by the Free Software Foundation, either version 3 of the + * License, or (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU Affero General Public License for more details. + * + * You should have received a copy of the GNU Affero General Public License + * along with this program. If not, see . + * + */ + +namespace OCA\Files_Sharing\BackgroundJob; + +use OCA\Files_Sharing\Command\CleanupRemoteStorages; +use OCP\AppFramework\Utility\ITimeFactory; +use OCP\BackgroundJob\TimedJob; +use Symfony\Component\Console\Input\ArrayInput; +use Symfony\Component\Console\Output\NullOutput; + +/** + * Background job for the Command CleanupRemoteStorages + */ +class CleanupRemoteStoragesJob extends TimedJob { + /** + * @var CleanupRemoteStorages + */ + private $remoteStorages; + + /** + * CleanupRemoteStoragesJob constructor. + * @param ITimeFactory $time + * @param CleanupRemoteStorages $remoteStorages + */ + private function __construct(ITimeFactory $time, CleanupRemoteStorages $remoteStorages) { + parent::__construct($time); + $this->remoteStorages = $remoteStorages; + + // Only once a week + parent::setInterval(604800); + } + + /** + * @param $argument + * @return void + */ + protected function run($argument) { + $input = new ArrayInput(array( + 'command' => 'sharing:cleanup-remote-storages', + '--dry-run' => "" + )); + $output = new NullOutput(); + $this->remoteStorages->execute($input, $output); + } +}