Merge pull request #18248 from nextcloud/backport/18241/stable16

rullzer · web-flow · commit 8e74b232edc1 · 2019-12-09T21:27:59.000+01:00
[stable16] Allow to unfavorite all files
diff --git a/apps/files/js/tagsplugin.js b/apps/files/js/tagsplugin.js
@@ -69,7 +69,7 @@
 			apppath=appfolder.substring(1, appfolder.length);
 		}
 
-		$(listULElements).find('[data-dir="' + apppath + '"]').remove();
+		$(listULElements).find('[data-dir="' + _.escape(apppath) + '"]').remove();
 
 		if (listULElements.childElementCount === 0) {
 			var collapsibleButton = $(listULElements).parent().find('button.collapse');
@@ -98,7 +98,6 @@
 			apppath = appfolder.substring(1, appfolder.length);
 		}
 		var url = OC.generateUrl('/apps/files/?dir=' + apppath + '&view=files');
-		
 
 		var innerTagA = document.createElement('A');
 		innerTagA.setAttribute("href", url);

Original file line number	Diff line number	Diff line change
`@@ -69,7 +69,7 @@`
`69`	`69`	`apppath=appfolder.substring(1, appfolder.length);`
`70`	`70`	`}`
`71`	`71`
`72`		`- $(listULElements).find('[data-dir="' + apppath + '"]').remove();`
	`72`	`+ $(listULElements).find('[data-dir="' + _.escape(apppath) + '"]').remove();`
`73`	`73`
`74`	`74`	`if (listULElements.childElementCount === 0) {`
`75`	`75`	`var collapsibleButton = $(listULElements).parent().find('button.collapse');`
`@@ -98,7 +98,6 @@`
`98`	`98`	`apppath = appfolder.substring(1, appfolder.length);`
`99`	`99`	`}`
`100`	`100`	`var url = OC.generateUrl('/apps/files/?dir=' + apppath + '&view=files');`
`101`		`-`
`102`	`101`
`103`	`102`	`var innerTagA = document.createElement('A');`
`104`	`103`	`innerTagA.setAttribute("href", url);`