Skip to content

Commit 8a9a833

Browse files
authored
Merge pull request #24795 from nextcloud/backport/23319/stable19
[stable19] Fix Argon2 descriptions
2 parents 0be0f46 + ef18e45 commit 8a9a833

File tree

1 file changed

+13
-14
lines changed

1 file changed

+13
-14
lines changed

config/config.sample.php

Lines changed: 13 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1505,27 +1505,26 @@
15051505
*/
15061506

15071507
/**
1508-
* The allowed maximum memory in KiB to be used by the algorithm for computing a
1509-
* hash. The smallest possible value is 8. Values that undershoot the minimum
1510-
* will be ignored in favor of the default.
1508+
* The number of CPU threads to be used by the algorithm for computing a hash.
1509+
* The value must be an integer, and the minimum value is 1. Rationally it does
1510+
* not help to provide a number higher than the available threads on the machine.
1511+
* Values that undershoot the minimum will be ignored in favor of the minimum.
15111512
*/
1512-
'hashingMemoryCost' => PASSWORD_ARGON2_DEFAULT_MEMORY_COST,
1513+
'hashingThreads' => PASSWORD_ARGON2_DEFAULT_THREADS,
15131514

15141515
/**
1515-
* The allowed maximum time in seconds that can be used by the algorithm for
1516-
* computing a hash. The value must be an integer, and the minimum value is 1.
1517-
* Values that undershoot the minimum will be ignored in favor of the default.
1516+
* The memory in KiB to be used by the algorithm for computing a hash. The value
1517+
* must be an integer, and the minimum value is 8 times the number of CPU threads.
1518+
* Values that undershoot the minimum will be ignored in favor of the minimum.
15181519
*/
1519-
'hashingTimeCost' => PASSWORD_ARGON2_DEFAULT_TIME_COST,
1520+
'hashingMemoryCost' => PASSWORD_ARGON2_DEFAULT_MEMORY_COST,
15201521

15211522
/**
1522-
* The allowed number of CPU threads that can be used by the algorithm for
1523-
* computing a hash. The value must be an integer, and the minimum value is 1.
1524-
* Rationally it does not help to provide a number higher than the available
1525-
* threads on the machine. Values that undershoot the minimum will be ignored
1526-
* in favor of the default.
1523+
* The number of iterations that are used by the algorithm for computing a hash.
1524+
* The value must be an integer, and the minimum value is 1. Values that
1525+
* undershoot the minimum will be ignored in favor of the minimum.
15271526
*/
1528-
'hashingThreads' => PASSWORD_ARGON2_DEFAULT_THREADS,
1527+
'hashingTimeCost' => PASSWORD_ARGON2_DEFAULT_TIME_COST,
15291528

15301529
/**
15311530
* The hashing cost used by hashes generated by Nextcloud

0 commit comments

Comments
 (0)