Merge pull request #20766 from nextcloud/bug/fix-reminders-with-empty-calendar-data

Consider only reminders with calendar data

Author: ChristophWurst

apps/dav/lib/AppInfo/Application.php

@@ -39,6 +39,7 @@
 use OCA\DAV\CalDAV\CalDavBackend;
 use OCA\DAV\CalDAV\CalendarManager;
 use OCA\DAV\CalDAV\CalendarProvider;
+use OCA\DAV\CalDAV\Reminder\Backend as ReminderBackend;
 use OCA\DAV\CalDAV\Reminder\NotificationProvider\AudioProvider;
 use OCA\DAV\CalDAV\Reminder\NotificationProvider\EmailProvider;
 use OCA\DAV\CalDAV\Reminder\NotificationProvider\PushProvider;
@@ -306,6 +307,9 @@ function (GenericEvent $event) use ($container, $serverContainer) {
 				/** @var CalDavBackend $calDavBackend */
 				$calDavBackend = $container->query(CalDavBackend::class);
 				$calDavBackend->purgeAllCachedEventsForSubscription($subscriptionData['id']);
+				/** @var ReminderBackend $calDavBackend */
+				$reminderBackend = $container->query(ReminderBackend::class);
+				$reminderBackend->cleanRemindersForCalendar($subscriptionData['id']);
 			}
 		);
 

apps/dav/lib/CalDAV/Reminder/Backend.php

@@ -67,8 +67,8 @@ public function getRemindersToProcess():array {
 		$query->select(['cr.*', 'co.calendardata', 'c.displayname', 'c.principaluri'])
 			->from('calendar_reminders', 'cr')
 			->where($query->expr()->lte('cr.notification_date', $query->createNamedParameter($this->timeFactory->getTime())))
-			->leftJoin('cr', 'calendarobjects', 'co', $query->expr()->eq('cr.object_id', 'co.id'))
-			->leftJoin('cr', 'calendars', 'c', $query->expr()->eq('cr.calendar_id', 'c.id'));
+			->join('cr', 'calendarobjects', 'co', $query->expr()->eq('cr.object_id', 'co.id'))
+			->join('cr', 'calendars', 'c', $query->expr()->eq('cr.calendar_id', 'c.id'));
 		$stmt = $query->execute();
 
 		return array_map(

apps/dav/lib/CalDAV/Reminder/ReminderService.php

@@ -119,6 +119,10 @@ public function processReminders():void {
 				? stream_get_contents($reminder['calendardata'])
 				: $reminder['calendardata'];
 
+			if (!$calendarData) {
+				continue;
+			}
+
 			$vcalendar = $this->parseCalendarData($calendarData);
 			if (!$vcalendar) {
 				$this->backend->removeReminder($reminder['id']);
@@ -168,6 +172,10 @@ public function onCalendarObjectCreate(array $objectData):void {
 			? stream_get_contents($objectData['calendardata'])
 			: $objectData['calendardata'];
 
+		if (!$calendarData) {
+			return;
+		}
+
 		/** @var VObject\Component\VCalendar $vcalendar */
 		$vcalendar = $this->parseCalendarData($calendarData);
 		if (!$vcalendar) {