Merge pull request #51512 from nextcloud/fix/comments/activity-rich-subject-parameters

provokateurin · web-flow · commit 6bd3f09c8eab · 2025-03-17T10:35:02.000+01:00
fix(comments): Fix activity rich subject parameters
diff --git a/apps/comments/lib/Activity/Provider.php b/apps/comments/lib/Activity/Provider.php
@@ -174,10 +174,13 @@ protected function parseMessage(IEvent $event): void {
 		}
 	}
 
+	/**
+	 * @return array<string, string>
+	 */
 	protected function generateFileParameter(int $id, string $path): array {
 		return [
 			'type' => 'file',
-			'id' => $id,
+			'id' => (string)$id,
 			'name' => basename($path),
 			'path' => $path,
 			'link' => $this->url->linkToRouteAbsolute('files.viewcontroller.showFile', ['fileid' => $id]),

Original file line number	Diff line number	Diff line change
`@@ -174,10 +174,13 @@ protected function parseMessage(IEvent $event): void {`
`174`	`174`	`}`
`175`	`175`	`}`
`176`	`176`
	`177`	`+ /**`
	`178`	`+ * @return array<string, string>`
	`179`	`+ */`
`177`	`180`	`protected function generateFileParameter(int $id, string $path): array {`
`178`	`181`	`return [`
`179`	`182`	`'type' => 'file',`
`180`		`- 'id' => $id,`
	`183`	`+ 'id' => (string)$id,`
`181`	`184`	`'name' => basename($path),`
`182`	`185`	`'path' => $path,`
`183`	`186`	`'link' => $this->url->linkToRouteAbsolute('files.viewcontroller.showFile', ['fileid' => $id]),`