fix(comments): Do not set parent when instantiating activity tab plugin

artonge · artonge · commit 65faecc4e87f · 2025-06-02T17:16:48.000+02:00
This is necessary as the `context` variable is a vue3 instance, and vue 2 do not know how to handle it properly.

Also, as far as I understand it, it is not needed.

Signed-off-by: Louis Chemineau &lt;louis@chmn.me&gt;
diff --git a/apps/comments/src/comments-activity-tab.ts b/apps/comments/src/comments-activity-tab.ts
@@ -29,7 +29,6 @@ export function registerCommentsPlugins() {
 			}
 			ActivityTabPluginInstance = new ActivityTabPluginView({
 				el,
-				parent: context,
 				pinia,
 				propsData: {
 					reloadCallback: reload,

Original file line number	Diff line number	Diff line change
`@@ -29,7 +29,6 @@ export function registerCommentsPlugins() {`
`29`	`29`	`}`
`30`	`30`	`ActivityTabPluginInstance = new ActivityTabPluginView({`
`31`	`31`	`el,`
`32`		`- parent: context,`
`33`	`32`	`pinia,`
`34`	`33`	`propsData: {`
`35`	`34`	`reloadCallback: reload,`