Don't include unindexed is_backup in the query, it's ensured by the user_id leading underscore already

nickvergessen · nickvergessen · commit 658547d274e4 · 2022-02-15T16:06:33.000+01:00
Signed-off-by: Joas Schilling &lt;coding@schilljs.com&gt;
diff --git a/apps/user_status/lib/Db/UserStatusMapper.php b/apps/user_status/lib/Db/UserStatusMapper.php
@@ -101,8 +101,7 @@ public function findByUserId(string $userId, bool $isBackup = false):UserStatus
 		$qb
 			->select('*')
 			->from($this->tableName)
-			->where($qb->expr()->eq('user_id', $qb->createNamedParameter($isBackup ? '_' . $userId : $userId, IQueryBuilder::PARAM_STR)))
-			->andWhere($qb->expr()->eq('is_backup', $qb->createNamedParameter($isBackup, IQueryBuilder::PARAM_BOOL)));
+			->where($qb->expr()->eq('user_id', $qb->createNamedParameter($isBackup ? '_' . $userId : $userId, IQueryBuilder::PARAM_STR)));
 
 		return $this->findEntity($qb);
 	}

Original file line number	Diff line number	Diff line change
`@@ -101,8 +101,7 @@ public function findByUserId(string $userId, bool $isBackup = false):UserStatus`
`101`	`101`	`$qb`
`102`	`102`	`->select('*')`
`103`	`103`	`->from($this->tableName)`
`104`		`- ->where($qb->expr()->eq('user_id', $qb->createNamedParameter($isBackup ? '_' . $userId : $userId, IQueryBuilder::PARAM_STR)))`
`105`		`- ->andWhere($qb->expr()->eq('is_backup', $qb->createNamedParameter($isBackup, IQueryBuilder::PARAM_BOOL)));`
	`104`	`+ ->where($qb->expr()->eq('user_id', $qb->createNamedParameter($isBackup ? '_' . $userId : $userId, IQueryBuilder::PARAM_STR)));`
`106`	`105`
`107`	`106`	`return $this->findEntity($qb);`
`108`	`107`	`}`