Fix permittedPath comparison

Mickey Knox · szaimen · commit 4910724803d5 · 2022-03-08T10:17:55.000Z
Signed-off-by: Mickey Knox &lt;mickey@netfreaks.org&gt;
diff --git a/apps/settings/lib/Controller/CheckSetupController.php b/apps/settings/lib/Controller/CheckSetupController.php
@@ -482,7 +482,7 @@ protected function getOpcacheSetupRecommendations(): array {
 		// Check whether Nextcloud is allowed to use the OPcache API
 		$isPermitted = true;
 		$permittedPath = $this->iniGetWrapper->getString('opcache.restrict_api');
-		if (isset($permittedPath) && $permittedPath !== '' && !str_starts_with(\OC::$SERVERROOT, $permittedPath)) {
+		if (isset($permittedPath) && $permittedPath !== '' && !str_starts_with(\OC::$SERVERROOT, rtrim($permittedPath, '/'))) {
 			$isPermitted = false;
 		}
 

Original file line number	Diff line number	Diff line change
`@@ -482,7 +482,7 @@ protected function getOpcacheSetupRecommendations(): array {`
`482`	`482`	`// Check whether Nextcloud is allowed to use the OPcache API`
`483`	`483`	`$isPermitted = true;`
`484`	`484`	`$permittedPath = $this->iniGetWrapper->getString('opcache.restrict_api');`
`485`		`- if (isset($permittedPath) && $permittedPath !== '' && !str_starts_with(\OC::$SERVERROOT, $permittedPath)) {`
	`485`	`+ if (isset($permittedPath) && $permittedPath !== '' && !str_starts_with(\OC::$SERVERROOT, rtrim($permittedPath, '/'))) {`
`486`	`486`	`$isPermitted = false;`
`487`	`487`	`}`
`488`	`488`