fix(core): ensure unique vcategory

Signed-off-by: skjnldsv <skjnldsv@protonmail.com>

[skip ci]

Author: skjnldsv

core/Migrations/Version13000Date20170718121200.php

@@ -657,6 +657,7 @@ public function changeSchema(IOutput $output, \Closure $schemaClosure, array $op
 			$table->addIndex(['uid'], 'uid_index');
 			$table->addIndex(['type'], 'type_index');
 			$table->addIndex(['category'], 'category_index');
+			$table->addUniqueIndex(['uid', 'type', 'category'], 'unique_category_per_user');
 		}
 
 		if (!$schema->hasTable('vcategory_to_object')) {

core/Migrations/Version32000Date20250731062008.php

@@ -0,0 +1,106 @@
+<?php
+
+declare(strict_types=1);
+
+/**
+ * SPDX-FileCopyrightText: 2025 Nextcloud GmbH and Nextcloud contributors
+ * SPDX-License-Identifier: AGPL-3.0-or-later
+ */
+
+namespace OC\Core\Migrations;
+
+use Closure;
+use OCP\DB\ISchemaWrapper;
+use OCP\IDBConnection;
+use OCP\Migration\IOutput;
+use OCP\Migration\SimpleMigrationStep;
+use Override;
+
+/**
+ * Make sure vcategory entries are unique per user and type
+ * This migration will clean up existing duplicates
+ * and add a unique constraint to prevent future duplicates.
+ */
+class Version32000Date20250731062008 extends SimpleMigrationStep {
+	public function __construct(
+		private IDBConnection $connection,
+	) {
+	}
+
+	/**
+	 * @param IOutput $output
+	 * @param Closure(): ISchemaWrapper $schemaClosure
+	 * @param array $options
+	 */
+	#[Override]
+	public function preSchemaChange(IOutput $output, Closure $schemaClosure, array $options): void {
+		// Clean up duplicate categories before adding unique constraint
+		$this->cleanupDuplicateCategories($output);
+	}
+
+	/**
+	 * Clean up duplicate categories
+	 */
+	private function cleanupDuplicateCategories(IOutput $output) {
+		$output->info('Starting cleanup of duplicate vcategory records...');
+
+		// Find all categories, ordered to identify duplicates
+		$qb = $this->connection->getQueryBuilder();
+		$qb->select('id', 'uid', 'type', 'category')
+			->from('vcategory')
+			->orderBy('uid')
+			->addOrderBy('type')
+			->addOrderBy('category')
+			->addOrderBy('id');
+
+		$result = $qb->executeQuery();
+
+		$seen = [];
+		$duplicateCount = 0;
+
+		while ($category = $result->fetch()) {
+			$key = $category['uid'] . '|' . $category['type'] . '|' . $category['category'];
+			$categoryId = (int)$category['id'];
+
+			if (!isset($seen[$key])) {
+				// First occurrence - keep this one
+				$seen[$key] = $categoryId;
+				continue;
+			}
+
+			// Duplicate found
+			$keepId = $seen[$key];
+			$duplicateCount++;
+
+			$output->info("Found duplicate: keeping ID $keepId, removing ID $categoryId");
+
+			// Update object references
+			$updateQb = $this->connection->getQueryBuilder();
+			$updateQb->update('vcategory_to_object')
+				->set('categoryid', $updateQb->createNamedParameter($keepId))
+				->where($updateQb->expr()->eq('categoryid', $updateQb->createNamedParameter($categoryId)));
+
+			$affectedRows = $updateQb->executeStatement();
+			if ($affectedRows > 0) {
+				$output->info(" - Updated $affectedRows object references from category $categoryId to $keepId");
+			}
+
+			// Remove duplicate category record
+			$deleteQb = $this->connection->getQueryBuilder();
+			$deleteQb->delete('vcategory')
+				->where($deleteQb->expr()->eq('id', $deleteQb->createNamedParameter($categoryId)));
+
+			$deleteQb->executeStatement();
+			$output->info(" - Deleted duplicate category record ID $categoryId");
+
+		}
+
+		$result->closeCursor();
+
+		if ($duplicateCount === 0) {
+			$output->info('No duplicate categories found');
+		} else {
+			$output->info("Duplicate cleanup completed - processed $duplicateCount duplicates");
+		}
+	}
+}

lib/composer/composer/autoload_classmap.php

@@ -1380,6 +1380,7 @@
     'OC\\Core\\Events\\PasswordResetEvent' => $baseDir . '/core/Events/PasswordResetEvent.php',
     'OC\\Core\\Exception\\LoginFlowV2NotFoundException' => $baseDir . '/core/Exception/LoginFlowV2NotFoundException.php',
     'OC\\Core\\Exception\\ResetPasswordException' => $baseDir . '/core/Exception/ResetPasswordException.php',
+    'OC\\Core\\Listener\\AddMissingIndicesListener' => $baseDir . '/core/Listener/AddMissingIndicesListener.php',
     'OC\\Core\\Listener\\BeforeMessageLoggedEventListener' => $baseDir . '/core/Listener/BeforeMessageLoggedEventListener.php',
     'OC\\Core\\Listener\\BeforeTemplateRenderedListener' => $baseDir . '/core/Listener/BeforeTemplateRenderedListener.php',
     'OC\\Core\\Middleware\\TwoFactorMiddleware' => $baseDir . '/core/Middleware/TwoFactorMiddleware.php',

lib/composer/composer/autoload_static.php

@@ -1429,6 +1429,7 @@ class ComposerStaticInit749170dad3f5e7f9ca158f5a9f04f6a2
         'OC\\Core\\Events\\PasswordResetEvent' => __DIR__ . '/../../..' . '/core/Events/PasswordResetEvent.php',
         'OC\\Core\\Exception\\LoginFlowV2NotFoundException' => __DIR__ . '/../../..' . '/core/Exception/LoginFlowV2NotFoundException.php',
         'OC\\Core\\Exception\\ResetPasswordException' => __DIR__ . '/../../..' . '/core/Exception/ResetPasswordException.php',
+        'OC\\Core\\Listener\\AddMissingIndicesListener' => __DIR__ . '/../../..' . '/core/Listener/AddMissingIndicesListener.php',
         'OC\\Core\\Listener\\BeforeMessageLoggedEventListener' => __DIR__ . '/../../..' . '/core/Listener/BeforeMessageLoggedEventListener.php',
         'OC\\Core\\Listener\\BeforeTemplateRenderedListener' => __DIR__ . '/../../..' . '/core/Listener/BeforeTemplateRenderedListener.php',
         'OC\\Core\\Middleware\\TwoFactorMiddleware' => __DIR__ . '/../../..' . '/core/Middleware/TwoFactorMiddleware.php',

lib/private/Tags.php

@@ -273,7 +273,6 @@ public function add(string $name) {
 			return false;
 		}
 		if ($this->userHasTag($name, $this->user)) {
-			// TODO use unique db properties instead of an additional check
 			$this->logger->debug(__METHOD__ . ' Tag with name already exists', ['app' => 'core']);
 			return false;
 		}