Merge pull request #14451 from nextcloud/bugfix/noid/error-message-on-password-change

Check if password can be changed for the users backend in OCS api

Author: MorrisJobke

apps/provisioning_api/lib/Controller/UsersController.php

@@ -513,6 +513,9 @@ public function editUser(string $userId, string $key, string $value): DataRespon
 				break;
 			case 'password':
 				try {
+					if (!$targetUser->canChangePassword()) {
+						throw new OCSException('Setting the password is not supported by the users backend', 103);
+					}
 					$targetUser->setPassword($value);
 				} catch (HintException $e) { // password policy error
 					throw new OCSException($e->getMessage(), 103);

apps/provisioning_api/tests/Controller/UsersControllerTest.php

@@ -1270,6 +1270,10 @@ public function testEditUserRegularUserSelfEditChangePassword() {
 			->method('get')
 			->with('UserToEdit')
 			->will($this->returnValue($targetUser));
+		$targetUser
+			->expects($this->once())
+			->method('canChangePassword')
+			->will($this->returnValue(true));
 		$targetUser
 			->expects($this->once())
 			->method('setPassword')