fix: attempt to repair upload folder permissions

Signed-off-by: Robin Appelman <robin@icewind.nl>

Author: icewind1991

apps/dav/lib/RootCollection.php

@@ -175,6 +175,7 @@ public function __construct() {
 			\OC::$server->query(CleanupService::class),
 			$rootFolder,
 			$userSession,
+			$logger,
 		);
 		$uploadCollection->disableListing = $disableListing;
 

apps/dav/lib/Upload/RootCollection.php

@@ -28,6 +28,7 @@
 
 use OCP\Files\IRootFolder;
 use OCP\IUserSession;
+use Psr\Log\LoggerInterface;
 use Sabre\DAVACL\AbstractPrincipalCollection;
 use Sabre\DAVACL\PrincipalBackend;
 
@@ -37,6 +38,7 @@ public function __construct(PrincipalBackend\BackendInterface $principalBackend,
 		private CleanupService $cleanupService,
 		private IRootFolder $rootFolder,
 		private IUserSession $userSession,
+		private LoggerInterface $logger,
 	) {
 		parent::__construct($principalBackend, $principalPrefix);
 	}
@@ -45,7 +47,7 @@ public function __construct(PrincipalBackend\BackendInterface $principalBackend,
 	 * @inheritdoc
 	 */
 	public function getChildForPrincipal(array $principalInfo): UploadHome {
-		return new UploadHome($principalInfo, $this->cleanupService, $this->rootFolder, $this->userSession);
+		return new UploadHome($principalInfo, $this->cleanupService, $this->rootFolder, $this->userSession, $this->logger);
 	}
 
 	/**

apps/dav/lib/Upload/UploadHome.php

@@ -27,10 +27,12 @@
 
 use OC\Files\View;
 use OCA\DAV\Connector\Sabre\Directory;
+use OCP\Constants;
 use OCP\Files\Folder;
 use OCP\Files\IRootFolder;
 use OCP\Files\NotFoundException;
 use OCP\IUserSession;
+use Psr\Log\LoggerInterface;
 use Sabre\DAV\Exception\Forbidden;
 use Sabre\DAV\ICollection;
 
@@ -42,6 +44,7 @@ public function __construct(
 		private CleanupService $cleanupService,
 		private IRootFolder $rootFolder,
 		private IUserSession $userSession,
+		private LoggerInterface $logger,
 	) {
 	}
 
@@ -109,6 +112,12 @@ private function getUploadFolder(): Folder {
 
 	private function impl(): Directory {
 		$folder = $this->getUploadFolder();
+		if (!$folder->isCreatable()) {
+			$user = $this->userSession->getUser();
+			$this->logger->warning('Upload home not writable for ' . $user->getUID() . ', attempting to fix', ['permissions' => $folder->getPermissions()]);
+			$cache = $folder->getStorage()->getCache();
+			$cache->update($folder->getId(), ['permissions', Constants::PERMISSION_ALL]);
+		}
 		$view = new View($folder->getPath());
 		return new Directory($view, $folder);
 	}