refactor: Port External\Manager to the query builder

Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com>

Author: CarlSchwan

apps/dav/lib/Migration/BuildSocialSearchIndex.php

@@ -15,9 +15,9 @@
 class BuildSocialSearchIndex implements IRepairStep {
 
 	public function __construct(
-		readonly private IDBConnection $db,
-		readonly private IJobList $jobList,
-		readonly private IAppConfig $config,
+		private readonly IDBConnection $db,
+		private readonly IJobList $jobList,
+		private readonly IAppConfig $config,
 	) {
 	}
 
@@ -30,7 +30,7 @@ public function getName(): string {
 	 */
 	public function run(IOutput $output) {
 		// only run once
-		if ($this->config->getValueString('dav', 'builtSocialSearchIndex') === 'yes') {
+		if ($this->config->getValueBool('dav', 'builtSocialSearchIndex')) {
 			$output->info('Repair step already executed');
 			return;
 		}
@@ -52,6 +52,6 @@ public function run(IOutput $output) {
 		]);
 
 		// no need to redo the repair during next upgrade
-		$this->config->setValueString('dav', 'builtSocialSearchIndex', 'yes');
+		$this->config->setValueBool('dav', 'builtSocialSearchIndex', true);
 	}
 }

apps/dav/tests/unit/BackgroundJob/CleanupInvitationTokenJobTest.php

@@ -39,7 +39,6 @@ public function testRun(): void {
 
 		$queryBuilder = $this->createMock(IQueryBuilder::class);
 		$expr = $this->createMock(IExpressionBuilder::class);
-		$stmt = $this->createMock(\Doctrine\DBAL\Driver\Statement::class);
 
 		$this->dbConnection->expects($this->once())
 			->method('getQueryBuilder')
@@ -72,9 +71,9 @@ public function testRun(): void {
 			->with($function)
 			->willReturn($queryBuilder);
 		$queryBuilder->expects($this->once())
-			->method('execute')
+			->method('executeStatement')
 			->with()
-			->willReturn($stmt);
+			->willReturn(1);
 
 		$this->backgroundJob->run([]);
 	}

apps/dav/tests/unit/Migration/RefreshWebcalJobRegistrarTest.php

@@ -54,7 +54,7 @@ public function testRun(): void {
 			->with('calendarsubscriptions')
 			->willReturn($queryBuilder);
 		$queryBuilder->expects($this->once())
-			->method('execute')
+			->method('executeQuery')
 			->willReturn($statement);
 
 		$statement->expects($this->exactly(4))

apps/dav/tests/unit/Migration/RemoveDeletedUsersCalendarSubscriptionsTest.php

@@ -72,7 +72,7 @@ public function testRun(array $subscriptions, array $userExists, int $deletions)
 
 		$result = $this->createMock(IResult::class);
 
-		$qb->method('execute')
+		$qb->method('executeQuery')
 			->willReturn($result);
 
 		$result->expects($this->once())