fix(files_reminder): Replace error log by setup check

Signed-off-by: Louis Chemineau <louis@chmn.me>

Author: artonge

apps/files_reminders/lib/AppInfo/Application.php

@@ -42,5 +42,7 @@ public function register(IRegistrationContext $context): void {
 		$context->registerEventListener(UserDeletedEvent::class, UserDeletedListener::class);
 
 		$context->registerEventListener(LoadAdditionalScriptsEvent::class, LoadAdditionalScriptsListener::class);
+
+		$context->registerSetupCheck(NeedNotificationsApp::class);
 	}
 }

apps/files_reminders/lib/Listener/LoadAdditionalScriptsListener.php

@@ -31,7 +31,6 @@ public function handle(Event $event): void {
 		}
 
 		if (!$this->appManager->isEnabledForUser('notifications')) {
-			$this->logger->info('Skipped registering the `files_reminders` app because the `notifications` app is disabled.', ['app' => 'files_reminders']);
 			return;
 		}
 

apps/files_reminders/lib/SetupChecks/NeedNotificationsApp.php

@@ -0,0 +1,37 @@
+<?php
+
+declare(strict_types=1);
+
+/**
+ * SPDX-FileCopyrightText: 2023 Nextcloud GmbH and Nextcloud contributors
+ * SPDX-License-Identifier: AGPL-3.0-or-later
+ */
+
+namespace OCA\DAV\SetupChecks;
+
+use OCP\App\IAppManager;
+use OCP\SetupCheck\ISetupCheck;
+use OCP\SetupCheck\SetupResult;
+
+class NeedNotificationsApp implements ISetupCheck {
+	public function __construct(
+		private IAppManager $appManager,
+	) {
+	}
+
+	public function getName(): string {
+		return $this->l10n->t('Files reminder');
+	}
+
+	public function getCategory(): string {
+		return 'system';
+	}
+
+	public function run(): SetupResult {
+		if ($this->appManager->isInstalled('notifications')) {
+			return SetupResult::success($this->l10n->t('This files_reminder can work properly.'));
+		} else {
+			return SetupResult::warning($this->l10n->t('The files_reminder app needs the notification app to work properly. You should either enable notifications or disable files_reminder.'));
+		}
+	}
+}