Merge pull request #51295 from nextcloud/backport/51280/stable31

artonge · web-flow · commit 0a9a14d31969 · 2025-03-05T18:45:16.000+01:00
[stable31] fix(login): Properly target public page with attribute
diff --git a/lib/private/AppFramework/Middleware/FlowV2EphemeralSessionsMiddleware.php b/lib/private/AppFramework/Middleware/FlowV2EphemeralSessionsMiddleware.php
@@ -10,6 +10,7 @@
 use OC\AppFramework\Utility\ControllerMethodReflector;
 use OC\Core\Controller\ClientFlowLoginV2Controller;
 use OCP\AppFramework\Controller;
+use OCP\AppFramework\Http\Attribute\PublicPage;
 use OCP\AppFramework\Middleware;
 use OCP\ISession;
 use OCP\IUserSession;
@@ -38,7 +39,7 @@ public function beforeController(Controller $controller, string $methodName) {
 		}
 
 		$reflectionMethod = new ReflectionMethod($controller, $methodName);
-		if (!empty($reflectionMethod->getAttributes('PublicPage'))) {
+		if (!empty($reflectionMethod->getAttributes(PublicPage::class))) {
 			return;
 		}
 

Original file line number	Diff line number	Diff line change
`@@ -10,6 +10,7 @@`
`10`	`10`	`use OC\AppFramework\Utility\ControllerMethodReflector;`
`11`	`11`	`use OC\Core\Controller\ClientFlowLoginV2Controller;`
`12`	`12`	`use OCP\AppFramework\Controller;`
	`13`	`+use OCP\AppFramework\Http\Attribute\PublicPage;`
`13`	`14`	`use OCP\AppFramework\Middleware;`
`14`	`15`	`use OCP\ISession;`
`15`	`16`	`use OCP\IUserSession;`
`@@ -38,7 +39,7 @@ public function beforeController(Controller $controller, string $methodName) {`
`38`	`39`	`}`
`39`	`40`
`40`	`41`	`$reflectionMethod = new ReflectionMethod($controller, $methodName);`
`41`		`- if (!empty($reflectionMethod->getAttributes('PublicPage'))) {`
	`42`	`+ if (!empty($reflectionMethod->getAttributes(PublicPage::class))) {`
`42`	`43`	`return;`
`43`	`44`	`}`
`44`	`45`