Skip to content

fix: check if template fields should be extracted #4713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 27, 2025
Merged

fix: check if template fields should be extracted #4713

merged 2 commits into from
May 27, 2025

Conversation

@elzody
Copy link
Contributor

@elzody elzody commented Apr 28, 2025 •
edited
Loading

Summary

With the new server changes, we need to check if the event tells us to fetch the fields or not. If the fields should be extracted, then we do that. On the server side, this will only be triggered once the user makes a template selection, and only that template will be sent.

The documentation has been updated for the server pull request, and the templates.spec.js tests have been expanded a bit in this pull request to verify that no template fields are extracted at first.

Checklist

  • Code is properly formatted
  • Sign-off message is added to all commits
  • Documentation (manuals or wiki) has been updated or is not required

@elzody elzody added the 2. developing Work in progress label Apr 28, 2025
@elzody elzody self-assigned this Apr 28, 2025
@elzody elzody mentioned this pull request Apr 28, 2025
Merged
4 tasks
@elzody elzody force-pushed the fix/templates-loading branch from 153be00 to 045926a Compare May 1, 2025 21:21
@elzody elzody force-pushed the fix/templates-loading branch from 045926a to aaaafb6 Compare May 9, 2025 21:00
@github-project-automation github-project-automation bot moved this to 🧭 Planning evaluation (don't pick) in 📝 Office team May 19, 2025
@elzody elzody moved this from 🧭 Planning evaluation (don't pick) to 🏗️ In progress in 📝 Office team May 19, 2025
@juliusknorr
Copy link
Member

This is obsolete with the slightly different approach in nextcloud/server#52514, right?

@elzody elzody force-pushed the fix/templates-loading branch from aaaafb6 to daa73bf Compare May 22, 2025 17:31
@elzody elzody marked this pull request as ready for review May 22, 2025 17:32
@elzody elzody requested a review from juliusknorr as a code owner May 22, 2025 17:32
@elzody
Copy link
Contributor Author

elzody commented May 22, 2025

@juliusknorr Not necessarily. We still need to check $event->shouldGetFields() to see if we should actually react to the event or not. So that will be here, plus an edit to some tests.

@elzody elzody force-pushed the fix/templates-loading branch from daa73bf to cc38527 Compare May 22, 2025 18:40
@elzody elzody moved this from 🏗️ In progress to 👀 In review in 📝 Office team May 22, 2025
@elzody elzody added 3. to review Ready to be reviewed backport-request php Pull requests that update Php code javascript Pull requests that update Javascript code performance 🚀 feature: templates and removed 2. developing Work in progress labels May 22, 2025
juliusknorr
juliusknorr reviewed May 23, 2025
View reviewed changes
juliusknorr
juliusknorr requested changes May 23, 2025
View reviewed changes
Copy link
Member

@juliusknorr juliusknorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small addition to account for compatibility, but otherwise 👍

@elzody
feat: check if template fields should be extracted
770287f 
The `BeforeGetTemplatesEvent` now has a property that allows us
to check if the templates should be enhanced with fields or not.
If so, then we extract the fields, if not, simply do not.

Signed-off-by: Elizabeth Danzberger <lizzy7128@tutanota.de>
@elzody elzody force-pushed the fix/templates-loading branch from cc38527 to 770287f Compare May 23, 2025 19:17
@elzody
chore: supress psalm error
32c3327 
Signed-off-by: Elizabeth Danzberger <lizzy7128@tutanota.de>
@elzody elzody changed the title feat: send fields url extraction endpoint feat: check if template fields should be extracted May 23, 2025
@elzody elzody changed the title feat: check if template fields should be extracted fix: check if template fields should be extracted May 23, 2025
@juliusknorr juliusknorr merged commit 6e43e3b into main May 27, 2025
72 checks passed
@juliusknorr juliusknorr deleted the fix/templates-loading branch May 27, 2025 04:47
@github-project-automation github-project-automation bot moved this from 👀 In review to ☑️ Done in 📝 Office team May 27, 2025
@juliusknorr
Copy link
Member

/backport to stable31

@backportbot backportbot bot mentioned this pull request May 27, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@juliusknorr juliusknorr juliusknorr approved these changes

Assignees

@elzody elzody

Labels

3. to review Ready to be reviewed feature: templates javascript Pull requests that update Javascript code performance 🚀 php Pull requests that update Php code

Projects

📝 Office team
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

New file creation takes a really long time

3 participants

@elzody @juliusknorr