Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

show query backtrace in profiler #9

Merged
merged 1 commit into from
Apr 7, 2022
Merged

show query backtrace in profiler #9

merged 1 commit into from
Apr 7, 2022

Conversation

icewind1991
Copy link
Member

@icewind1991 icewind1991 commented Apr 4, 2022 •
edited
Loading

Makes it easier to figure out where a query comes from

See also nextcloud/server#31833

@icewind1991 icewind1991 mentioned this pull request Apr 4, 2022
Merged
CarlSchwan
CarlSchwan approved these changes Apr 4, 2022
View reviewed changes
Copy link
Member

@CarlSchwan CarlSchwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a few style warnings in the diff but other than that it looks good. Thanks 👍

@icewind1991 icewind1991 force-pushed the profile-db-backtrace branch 2 times, most recently from adca8e0 to 6992968 Compare April 5, 2022 12:00
@CarlSchwan
Copy link
Member

While trying this locally I found two minor issues in the backtrace component:

  • sometimes the PHP backtrace has undefined file location
  • array_map and other lambda don't have a file.class and file.type

Both cases should be handled now :)

@icewind1991 icewind1991 force-pushed the profile-db-backtrace branch from 2f82d71 to d250db9 Compare April 5, 2022 13:24
@icewind1991
show query backtrace
1cabf22 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991 icewind1991 force-pushed the profile-db-backtrace branch from d250db9 to 1cabf22 Compare April 5, 2022 13:26
@CarlSchwan CarlSchwan merged commit ecfe9eb into master Apr 7, 2022
@delete-merged-branch delete-merged-branch bot deleted the profile-db-backtrace branch April 7, 2022 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CarlSchwan CarlSchwan CarlSchwan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@icewind1991 @CarlSchwan