Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Implement file selector #502

Closed
wants to merge 2 commits into from
Closed

Conversation

Mikescops
Copy link
Member

@Mikescops Mikescops commented Oct 20, 2020

Add file selection to the grid and open sidebar when selecting a new file.

grafik

Signed-off-by: Corentin Mors <corentin.mors@dashlane.com>
@Mikescops Mikescops added enhancement New feature or request 2. developing Work in progress labels Oct 20, 2020
@Mikescops Mikescops self-assigned this Oct 20, 2020
@Mikescops
Copy link
Member Author

I wanted to use a Set to keep track of selected files. It's very performant for such usage. But VueJS does not support Set and Map collections as reactive.
This indeed implies issues when updating the view.

Let me know if you have ideas on how we can improve this. I'm really not into using an array here tbh.

Signed-off-by: Corentin Mors <corentin.mors@dashlane.com>
@Mikescops
Copy link
Member Author

@skjnldsv done with the new changes

@jancborchardt I'd like advices on the design part

@jakobroehrl
Copy link
Contributor

@Mikescops
Could this be used for a multiselect actions?
#83

@jancborchardt
Copy link
Member

jancborchardt commented Oct 22, 2020

Cool! Here’s some design feedback:

  • The select icons look good, but don’t we want to use the Nextcloud-native ones? We can use them in monochrome (so not blue), but still the form could/should be the same?
  • It’s not possible to select items using keyboard only
  • The icon-checkmark shouldn’t be a span but a button, to be semantically correct?
  • The checkmark should be 44*44px clickable area as per our guidelines
  • For better feedback, it also should have cursor:pointer
  • Possibly a border (e.g. color-primary) around the pictures is better for highlighting than tinting it, since the tint actually makes the pictures less focused/visible.
  • I couldn’t see any change initially until I saw the selection bar on the bottom. The selection bar would be better at the top, just like we do it for Files and Mail too. :)
  • Of course we need some actions there, if we have a primary button it will also be more visible then.
  • Style-wise the selection bar should not be a hard bar, but floating buttons/text with a gradient of white to transparency down (just like the header in Mail)
  • Sometimes when clicking on the checkbox, the sidebar of the file opened? Not sure how exactly or why, can’t consistently reproduce

@Mikescops
Copy link
Member Author

@jancborchardt I will answer a few remarks first.

Yes the sidebar open when you click on files (I know it may not be wanted but I was looking for a simple way to open the sidebar and it just felt like the preview sidebar on Windows or Linux that is opened when you click on an image)

I first displayed the select bar at the bottom because if it's at the top it is hiding the navigation bar in the folders, so I don't know how you want to handle that.

@Mikescops
Copy link
Member Author

@jakobroehrl yes goal is to later add some action buttons, but one thing at the time.

@jancborchardt
Copy link
Member

Yes the sidebar open when you click on files (I know it may not be wanted but I was looking for a simple way to open the sidebar and it just felt like the preview sidebar on Windows or Linux that is opened when you click on an image)

Hm, since our focus is Photos and not "a photos view of files", clicking on an image should always open the image. We could discuss that it should also always open the sidebar, but I think that having the sidebar open without also having the viewer open is not really necessary.
(Also, in the case of the sidebar we should work on the possibility to not show the preview in the sidebar, as here it’s duplication of what is shown in the viewer.)

I first displayed the select bar at the bottom because if it's at the top it is hiding the navigation bar in the folders, so I don't know how you want to handle that.

It’s totally fine to replace the navigation bar as well, kind of like Android does. Full focus on the task at hand, which then is selection.

@skjnldsv
Copy link
Member

Implemented

@skjnldsv skjnldsv deleted the feature/file-selector branch September 20, 2022 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2. developing Work in progress enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants