Skip to content

[stable32] fix: Check cookie logged in event #932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CarlSchwan merged 1 commit into from
Apr 21, 2026
Merged

[stable32] fix: Check cookie logged in event #932

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions lib/AppInfo/Application.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@
use OCP\Security\Events\ValidatePasswordPolicyEvent;
use OCP\User\Events\BeforePasswordUpdatedEvent;
use OCP\User\Events\BeforeUserLoggedInEvent;
use OCP\User\Events\BeforeUserLoggedInWithCookieEvent;
use OCP\User\Events\PasswordUpdatedEvent;
use OCP\User\Events\UserLoggedInEvent;

Expand All @@ -43,6 +44,7 @@ public function register(IRegistrationContext $context): void {
$context->registerEventListener(BeforePasswordUpdatedEvent::class, BeforePasswordUpdatedEventListener::class);
$context->registerEventListener(PasswordUpdatedEvent::class, PasswordUpdatedEventListener::class);
$context->registerEventListener(BeforeUserLoggedInEvent::class, BeforeUserLoggedInEventListener::class);
$context->registerEventListener(BeforeUserLoggedInWithCookieEvent::class, BeforeUserLoggedInEventListener::class);
$context->registerEventListener(LoginFailedEvent::class, FailedLoginListener::class);
$context->registerEventListener(UserLoggedInEvent::class, SuccesfullLoginListener::class);
}
Expand Down
10 changes: 6 additions & 4 deletions lib/Listener/BeforeUserLoggedInEventListener.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,10 @@
use OCP\EventDispatcher\Event;
use OCP\EventDispatcher\IEventListener;
use OCP\User\Events\BeforeUserLoggedInEvent;
use OCP\User\Events\BeforeUserLoggedInWithCookieEvent;

/**
* @template-implements IEventListener<BeforeUserLoggedInEvent>
* @template-implements IEventListener<BeforeUserLoggedInEvent|BeforeUserLoggedInWithCookieEvent>
*/
class BeforeUserLoggedInEventListener implements IEventListener {
/** @var ComplianceService */
Expand All @@ -25,9 +26,10 @@ public function __construct(ComplianceService $complianceUpdater) {
}

public function handle(Event $event): void {
if (!$event instanceof BeforeUserLoggedInEvent) {
return;
if ($event instanceof BeforeUserLoggedInEvent) {
$this->complianceUpdater->entryControl($event->getUsername(), $event->getPassword());
} else {
$this->complianceUpdater->entryControl($event->getUsername(), null);
}
$this->complianceUpdater->entryControl($event->getUsername(), $event->getPassword());
}
}
Loading