Skip to content

Status support - No Push and browser notifications when in DND #724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 26, 2020
Merged

Status support - No Push and browser notifications when in DND #724

merged 3 commits into from
Aug 26, 2020

Conversation

nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Aug 26, 2020 •
edited
Loading

@nickvergessen nickvergessen added this to the Nextcloud 20 milestone Aug 26, 2020
@nickvergessen nickvergessen mentioned this pull request Aug 26, 2020
Merged
@nickvergessen
Set the user status as header, so clients can decide to not show noti…
a94e33e 
…fications

Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
Don't show browser notifications when the user is in DND
1ae825e 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
No push notifications when in DND
fea8749 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen force-pushed the feature/noid/status-support branch from 81400db to fea8749 Compare August 26, 2020 07:07
georgehrke
georgehrke approved these changes Aug 26, 2020
View reviewed changes
Copy link
Member

@georgehrke georgehrke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with Web Notifications and i can confirm it works 👍

I receive notifications for any status but DND.

Ivansss
Ivansss approved these changes Aug 26, 2020
View reviewed changes
Copy link
Member

@Ivansss Ivansss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with Browser and Push Notifications and it works 👍

@nickvergessen nickvergessen merged commit a971d99 into master Aug 26, 2020
@nickvergessen nickvergessen deleted the feature/noid/status-support branch August 26, 2020 13:08
@rullzer rullzer mentioned this pull request Aug 26, 2020
Merged
19 tasks
@nickvergessen nickvergessen mentioned this pull request Sep 7, 2020
Closed
@SystemKeeper SystemKeeper mentioned this pull request Oct 31, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@georgehrke georgehrke georgehrke approved these changes

@Ivansss Ivansss Ivansss approved these changes

@rullzer rullzer Awaiting requested review from rullzer

@jancborchardt jancborchardt Awaiting requested review from jancborchardt

Assignees
No one assigned
Labels
4. to release enhancement feature: backend 🛠️ feature: frontend 🖌️ feature: push 📲
Projects
None yet
Milestone
Nextcloud 20
Development

Successfully merging this pull request may close these issues.
3 participants
@nickvergessen @georgehrke @Ivansss