Skip to content

Dismiss notifications properly #508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 11, 2019
Merged

Dismiss notifications properly #508

merged 4 commits into from
Dec 11, 2019

Conversation

@rullzer
Copy link
Member

@rullzer rullzer commented Dec 9, 2019

@rullzer rullzer added this to the Nextcloud 18 milestone Dec 9, 2019
@rullzer rullzer mentioned this pull request Dec 9, 2019
Merged
nickvergessen
nickvergessen requested changes Dec 9, 2019
View reviewed changes
Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delete( needs to be adjusted as well

@nickvergessen
Copy link
Member

But hooking in delete( could run in circles... I will have a look later tonight

@rullzer
Copy link
Member Author

rullzer commented Dec 9, 2019

But hooking in delete( could run in circles... I will have a look later tonight

Delete calls deleteById so all roads pipe trough there if I'm not mistaken.

@nickvergessen
Copy link
Member

Which in return means we are grabbing the data too many times, but yeah you can continue like this for now. I will improve the duplicated queries later.

@nickvergessen
Copy link
Member

Pushed a fix

@nickvergessen
Copy link
Member

I guess unit tests need adjusting

@nickvergessen nickvergessen self-requested a review December 10, 2019 08:25
@rullzer
Dismiss notifications properly
a10ca51 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
nickvergessen
nickvergessen reviewed Dec 10, 2019
View reviewed changes
@nickvergessen @rullzer
Use known INotification instances when possible
3a97b78 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen @rullzer
Make sure we dont fail with an exception
0a25657 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@rullzer
Fix tests
36b64ec 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@rullzer rullzer mentioned this pull request Dec 11, 2019
Merged
43 tasks
@rullzer rullzer merged commit 423eec4 into master Dec 11, 2019
@rullzer rullzer deleted the enh/dismiss branch December 11, 2019 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nickvergessen nickvergessen nickvergessen requested changes

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

Assignees

No one assigned

Labels

3. to review enhancement

Projects

None yet

Milestone

Nextcloud 18

Development

Successfully merging this pull request may close these issues.

2 participants

@rullzer @nickvergessen