Skip to content

[stable31] fix: no notifications icon in header when using locale en #2459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 13, 2025
Merged

[stable31] fix: no notifications icon in header when using locale en #2459

merged 1 commit into from
Aug 13, 2025

Conversation

@st3iny
Copy link
Member

@st3iny st3iny commented Aug 13, 2025 •
edited
Loading

@st3iny
fix: no notifications icon in header when using locale en
de27a82 
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
@st3iny st3iny self-assigned this Aug 13, 2025
@st3iny st3iny requested a review from nickvergessen as a code owner August 13, 2025 12:42
@st3iny st3iny added bug 3. to review dependencies Pull requests that update a dependency file labels Aug 13, 2025
@st3iny st3iny changed the title fix: no notifications icon in header when using locale en [stable31] fix: no notifications icon in header when using locale en Aug 13, 2025
@st3iny st3iny requested review from Antreesy and susnux August 13, 2025 12:43
Antreesy
Antreesy approved these changes Aug 13, 2025
View reviewed changes
Copy link
Collaborator

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, thanks!

@blizzz
Copy link
Member

blizzz commented Aug 13, 2025

Approved to include despite freeze.

@blizzz blizzz merged commit 706e469 into stable31 Aug 13, 2025
40 of 41 checks passed
@blizzz blizzz deleted the fix/no-bell-on-en-locale branch August 13, 2025 14:05
@nextcloud-bot nextcloud-bot mentioned this pull request Aug 14, 2025
Merged
16 tasks
@github-actions
Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Antreesy Antreesy Antreesy approved these changes

@nickvergessen nickvergessen Awaiting requested review from nickvergessen nickvergessen is a code owner

@susnux susnux Awaiting requested review from susnux

Assignees

@st3iny st3iny

Labels

3. to review bug dependencies Pull requests that update a dependency file feedback-requested

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@st3iny @blizzz @Antreesy