Skip to content

fix(deps): migrate app to Vue 3 #2395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jun 23, 2025
Merged

fix(deps): migrate app to Vue 3 #2395

merged 7 commits into from
Jun 23, 2025

Conversation

@Antreesy
Copy link
Collaborator

image

@Antreesy Antreesy added this to the Nextcloud 32 milestone Jun 17, 2025
@Antreesy Antreesy requested review from DorraJaouad and ShGKme June 17, 2025 17:08
@Antreesy Antreesy self-assigned this Jun 17, 2025
@Antreesy Antreesy added 3. to review feature: frontend 🖌️ dependencies Pull requests that update a dependency file labels Jun 17, 2025
ShGKme
ShGKme reviewed Jun 17, 2025
View reviewed changes
nickvergessen
nickvergessen reviewed Jun 17, 2025
View reviewed changes
nickvergessen
nickvergessen reviewed Jun 17, 2025
View reviewed changes
@ShGKme

This comment was marked as resolved.

Sign in to view
@Antreesy Antreesy mentioned this pull request Jun 18, 2025
Merged
@Antreesy Antreesy force-pushed the fix/vue3 branch 2 times, most recently from cfa7a4f to 81dc62d Compare June 20, 2025 14:41
DorraJaouad
DorraJaouad reviewed Jun 20, 2025
View reviewed changes
src/NotificationsApp.vue
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:notification="notification" --> :notification
😇

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe later, when we'll come to a common ground on this

ShGKme
ShGKme reviewed Jun 20, 2025
View reviewed changes
ShGKme
ShGKme reviewed Jun 20, 2025
View reviewed changes
Copy link
Contributor

@ShGKme ShGKme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small change:

Before After
image image

@ShGKme

This comment has been minimized.

Sign in to view
@Antreesy
Copy link
Collaborator Author

Antreesy commented Jun 20, 2025 •
edited by ShGKme
Loading

One small change:

Fixing in nextcloud-vue

@ShGKme
Copy link
Contributor

ShGKme commented Jun 20, 2025

One small change:

Fixing in nextcloud-vue

:P

ShGKme
ShGKme approved these changes Jun 20, 2025
View reviewed changes
Copy link
Contributor

@ShGKme ShGKme left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the comments are not migration related

@Antreesy Antreesy marked this pull request as ready for review June 20, 2025 18:53
Antreesy added 4 commits June 23, 2025 08:51
@Antreesy
chore(deps): bump libraries to vue-compatible version
0aaade3 
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy
chore(vue3): update initializing Vue apps
87c0526 
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy
fix: migrate from using OC
d44ce60 
- Notification API expects canonical locale
- request token and session_keepalive available in nextcloud libs

Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy
chore(vue3): update eslint config for Vue3 features support
f27886d 
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy
Copy link
Collaborator Author

/compile

nextcloud-command and others added 2 commits June 23, 2025 06:56
@nextcloud-command
chore(assets): Recompile assets
94fb9e0 
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@Antreesy
chore: remove BSD-2-Clause license
35bdb56 
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy merged commit 556a6c0 into master Jun 23, 2025
41 checks passed
@Antreesy Antreesy deleted the fix/vue3 branch June 23, 2025 07:09
@Antreesy Antreesy mentioned this pull request Jun 23, 2025
Open
@ShGKme
Copy link
Contributor

ShGKme commented Jun 23, 2025

🥳

@skjnldsv skjnldsv mentioned this pull request Aug 19, 2025
Merged
@skjnldsv skjnldsv modified the milestones: Nextcloud 32, Nextcloud 33 Sep 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nickvergessen nickvergessen nickvergessen left review comments

@DorraJaouad DorraJaouad DorraJaouad left review comments

@ShGKme ShGKme ShGKme approved these changes

Assignees

@Antreesy Antreesy

Labels

3. to review dependencies Pull requests that update a dependency file feature: frontend 🖌️

Projects

None yet

Milestone

Nextcloud 32

Development

Successfully merging this pull request may close these issues.

7 participants

@Antreesy @ShGKme @nickvergessen @DorraJaouad @skjnldsv @nextcloud-command