Skip to content

Conversation

@come-nc
Copy link
Contributor

@come-nc come-nc commented May 19, 2025

This uses the new tests/autoload.php from nextcloud/server instead of messing directly with OC private autoloader.

See nextcloud/server#52951 and nextcloud/server#52945 for context.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc come-nc self-assigned this May 19, 2025
@come-nc come-nc requested a review from nickvergessen as a code owner May 19, 2025 16:03
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@github-actions
Copy link
Contributor

🐢 Performance warning.
It looks like the query count of the integration tests increased with this PR.
Database query count is now 8901 was 8600 (+3.5%)
Please check your code again. If you added a new test this can be expected and the base value in tests/Integration/base-query-count.txt can be increased.

@come-nc
Copy link
Contributor Author

come-nc commented May 19, 2025

🐢 Performance warning. It looks like the query count of the integration tests increased with this PR. Database query count is now 8901 was 8600 (+3.5%) Please check your code again. If you added a new test this can be expected and the base value in tests/Integration/base-query-count.txt can be increased.

I suppose this is from not clearing hooks?
What do you think @nickvergessen ?

I’ve put the hook thing in its own commit so it can be reverted if suited.

@nickvergessen
Copy link
Member

I suppose this is from not clearing hooks?

I'll debug this week. Also possible that someone changed server in a way that it adds 300 requests.
Because the measurement is only taken on Behat integration tests, so this change here shouldn't matter too much

@nickvergessen
Copy link
Member

@nickvergessen
Copy link
Member

Created #2353 for tracking

@nickvergessen nickvergessen merged commit 8625b2a into master May 19, 2025
47 checks passed
@nickvergessen nickvergessen deleted the fix/cleanup-tests-bootstrap branch May 19, 2025 20:33
@nickvergessen
Copy link
Member

/backport to stable31

@nickvergessen
Copy link
Member

/backport to stable30

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants