Skip to content

Remove deprecated at matcher from tests #1240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 2, 2022
Merged

Remove deprecated at matcher from tests #1240

merged 2 commits into from
Aug 2, 2022

Conversation

@come-nc
Copy link
Contributor

@come-nc come-nc commented Aug 1, 2022

Signed-off-by: Côme Chilliet come.chilliet@nextcloud.com

@come-nc
Remove deprecated at matcher from tests
f69d9a9 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc come-nc requested a review from nickvergessen as a code owner August 1, 2022 14:17
@come-nc come-nc self-assigned this Aug 1, 2022
@come-nc come-nc mentioned this pull request Aug 1, 2022
Closed
15 tasks
@come-nc come-nc added this to the Nextcloud 25 milestone Aug 1, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Aug 1, 2022

🐢 Performance warning.
It looks like the query count of the integration tests increased with this PR.
Database query count is now 9470 was 9300 (+1.82%)
Please check your code again. If you added a new test this can be expected and the base value in tests/Integration/base-query-count.txt can be increased.

@nickvergessen
Fix CS
abdd2fc 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2022

🐢 Performance warning.
It looks like the query count of the integration tests increased with this PR.
Database query count is now 9470 was 9300 (+1.82%)
Please check your code again. If you added a new test this can be expected and the base value in tests/Integration/base-query-count.txt can be increased.

@nickvergessen nickvergessen merged commit 129dfbc into master Aug 2, 2022
@nickvergessen nickvergessen deleted the fix/remove-at-matcher-in-tests branch August 2, 2022 07:11
@skjnldsv skjnldsv mentioned this pull request Aug 11, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

Assignees

@come-nc come-nc

Labels

3. to review technical debt

Projects

None yet

Milestone

Nextcloud 25

Development

Successfully merging this pull request may close these issues.

2 participants

@come-nc @nickvergessen