Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust to IUser change #1202

Merged
merged 1 commit into from
May 23, 2022
Merged

Adjust to IUser change #1202

merged 1 commit into from
May 23, 2022

Conversation

nickvergessen
Copy link
Member

Unbreak after merge of nextcloud/server#32378

@nickvergessen
Adjust to IUser change
c52eabc 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen added this to the Nextcloud 25 milestone May 23, 2022
@nickvergessen nickvergessen requested a review from CarlSchwan May 23, 2022 10:55
@github-actions
Copy link
Contributor

🐢 Performance warning.
It looks like the query count of the integration tests increased with this PR.
Database query count is now 9599 was 9300 (+3.21%)
Please check your code again. If you added a new test this can be expected and the base value in tests/Integration/base-query-count.txt can be increased.

come-nc
come-nc approved these changes May 23, 2022
View reviewed changes
Copy link
Contributor

@come-nc come-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be merged even if API change is reverted I think

@nickvergessen nickvergessen merged commit 67f7859 into master May 23, 2022
@nickvergessen nickvergessen deleted the bugfix/noid/IUser-update branch May 23, 2022 14:19
@nickvergessen nickvergessen mentioned this pull request May 23, 2022
Merged
@skjnldsv skjnldsv mentioned this pull request Aug 11, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@come-nc come-nc come-nc approved these changes

@CarlSchwan CarlSchwan Awaiting requested review from CarlSchwan

Assignees
No one assigned
Labels
3. to review bug
Projects
None yet
Milestone
Nextcloud 25
Development

Successfully merging this pull request may close these issues.
2 participants
@nickvergessen @come-nc