fix: Address review comments

Signed-off-by: Julius Härtl <jus@bitgrid.net>

Author: juliusknorr

src/App.vue

@@ -58,8 +58,8 @@ import PlusIcon from 'vue-material-design-icons/Plus.vue'
 import CogIcon from 'vue-material-design-icons/Cog.vue'
 
 import AppSettings from './components/AppSettings.vue'
-import EditorHint from './components/Modal/EditorHint.vue'
 import CategoriesList from './components/CategoriesList.vue'
+import EditorHint from './components/Modal/EditorHint.vue'
 
 import { config } from './config.js'
 import { fetchNotes, noteExists, createNote, undoDeleteNote } from './NotesService.js'
@@ -70,15 +70,15 @@ export default {
 
 	components: {
 		AppSettings,
+		CategoriesList,
+		CogIcon,
 		EditorHint,
 		NcAppContent,
 		NcAppNavigation,
 		NcAppNavigationNew,
 		NcAppNavigationItem,
 		NcContent,
-		CogIcon,
 		PlusIcon,
-		CategoriesList,
 	},
 
 	data() {

src/components/CategoriesList.vue

@@ -2,7 +2,7 @@
 	<Fragment>
 		<NcAppNavigationItem
 			:title="t('notes', 'All notes')"
-			:class="{ active: null === selectedCategory }"
+			:class="{ active: selectedCategory === null }"
 			@click.prevent.stop="onSelectCategory(null)"
 		>
 			<HistoryIcon slot="icon" :size="20" />

src/components/Note.vue

@@ -1,6 +1,6 @@
 <template>
-	<NoteRich v-if="ready && rich" :note-id="noteId" />
-	<NotePlain v-else-if="ready" :note-id="noteId" />
+	<NoteRich v-if="isRichMode" :note-id="noteId" />
+	<NotePlain v-else-if="isPlainMode" :note-id="noteId" />
 </template>
 <script>
 import NoteRich from './NoteRich.vue'
@@ -23,11 +23,11 @@ export default {
 	},
 
 	computed: {
-		rich() {
+		isRichMode() {
 			return window.oc_appswebroots.text && store.state.app.settings.noteMode === 'rich'
 		},
-		ready() {
-			return store.state.app.settings.noteMode !== null
+		isPlainMode() {
+			return store.state.app.settings.noteMode !== null && store.state.app.settings.noteMode !== 'rich'
 		},
 	},
 }

src/components/NoteItem.vue

@@ -47,8 +47,8 @@
 <script>
 import { NcListItem, NcActionButton } from '@nextcloud/vue'
 import AlertOctagonIcon from 'vue-material-design-icons/AlertOctagon.vue'
-import StarIcon from 'vue-material-design-icons/Star.vue'
 import FileDocumentOutlineIcon from 'vue-material-design-icons/FileDocumentOutline.vue'
+import StarIcon from 'vue-material-design-icons/Star.vue'
 import SidebarIcon from 'vue-material-design-icons/PageLayoutSidebarRight.vue'
 import { categoryLabel, routeIsNewNote } from '../Util.js'
 import { showError } from '@nextcloud/dialogs'
@@ -59,12 +59,12 @@ export default {
 	name: 'NoteItem',
 
 	components: {
-		NcActionButton,
-		NcListItem,
 		AlertOctagonIcon,
-		StarIcon,
 		FileDocumentOutlineIcon,
+		NcActionButton,
+		NcListItem,
 		SidebarIcon,
+		StarIcon,
 	},
 
 	props: {
@@ -115,7 +115,6 @@ export default {
 
 	methods: {
 		onNoteSelected(noteId) {
-			console.error('select note', noteId)
 			this.$emit('note-selected', noteId)
 		},
 		onToggleFavorite() {

src/components/Sidebar.vue

@@ -199,8 +199,8 @@ export default {
 			this.newTitle = newTitle
 		},
 
-		onRenameTitle(event) {
-			if (event && this.title !== this.newTitle) {
+		onRenameTitle() {
+			if (this.title !== this.newTitle) {
 				this.loading.title = true
 				setTitle(this.note.id, this.newTitle)
 					.catch(() => {