fix: respect setting for api endpoints

Signed-off-by: Roberto Vidal <roberto.vidal@ikumene.com>

Author: jrvidal

lib/Controller/Helper.php

@@ -75,12 +75,11 @@ public function getNotesAndCategories(
 		?string $category = null,
 		int $chunkSize = 0,
 		?string $chunkCursorStr = null,
-		?bool $showHidden = null,
 	) : array {
 		$userId = $this->getUID();
 		$chunkCursor = $chunkCursorStr ? ChunkCursor::fromString($chunkCursorStr) : null;
 		$lastUpdate = $chunkCursor->timeStart ?? new \DateTime();
-		$data = $this->notesService->getAll($userId, true, $showHidden); // auto-create notes folder if not exists
+		$data = $this->notesService->getAll($userId, true); // auto-create notes folder if not exists
 		$metaNotes = $this->metaService->getAll($userId, $data['notes']);
 
 		// if a category is requested, then ignore all other notes

lib/Controller/NotesApiController.php

@@ -66,9 +66,7 @@ public function index(
 			$this->settingsService->getAll($userId, true);
 			// load notes and categories
 			$exclude = explode(',', $exclude);
-			// show hidden folders by default, ignoring settings, so clients can handle them at will
-			$showHidden = true;
-			$data = $this->helper->getNotesAndCategories($pruneBefore, $exclude, $category, $chunkSize, $chunkCursor, $showHidden);
+			$data = $this->helper->getNotesAndCategories($pruneBefore, $exclude, $category, $chunkSize, $chunkCursor);
 			$notesData = $data['notesData'];
 			if (!$data['chunkCursor']) {
 				// if last chunk, then send all notes (pruned)

lib/Service/NotesService.php

@@ -30,13 +30,11 @@ public function __construct(
 		$this->noteUtil = $noteUtil;
 	}
 
-	public function getAll(string $userId, bool $autoCreateNotesFolder = false, ?bool $showHidden = null) : array {
+	public function getAll(string $userId, bool $autoCreateNotesFolder = false) : array {
 		$customExtension = $this->getCustomExtension($userId);
 		try {
 			$notesFolder = $this->getNotesFolder($userId, $autoCreateNotesFolder);
-			if ($showHidden === null) {
-				$showHidden = $this->settings->getValueBool($userId, 'showHidden');
-			}
+			$showHidden = $this->settings->getValueBool($userId, 'showHidden');
 			$data = self::gatherNoteFiles($customExtension, $notesFolder, $showHidden);
 			$fileIds = array_keys($data['files']);
 			// pre-load tags for all notes (performance improvement)