fix: drop unique index on mail_messages_snoozed.message_id #8800
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohannesGGE
force-pushed
the
fix-snooze-index
branch
from
ab3c0a3 to
276dfe5
Compare
kesselb
reviewed
Aug 23, 2023
| throw $e; | ||
| } | ||
|
|
||
| $messageId = $message['messageId']; |
There was a problem hiding this comment.
Why would findMessageIdsByThreadRoot return null for messageId?
There was a problem hiding this comment.
You're right, messageId shouldn't be null. I just adapted the pattern from the $message->getMessageId(); where the null check was needed.
kesselb
reviewed
Aug 23, 2023
lib/Service/SnoozeService.php
Outdated
| } | ||
|
|
||
| $this->messageSnoozeMapper->deleteByMessageIds(array($messageId)); |
There was a problem hiding this comment.
Suggested change
| $this->messageSnoozeMapper->deleteByMessageIds(array($messageId)); | |
| $this->messageSnoozeMapper->deleteByMessageIds([$messageId]); |
kesselb
reviewed
Aug 23, 2023
lib/Service/SnoozeService.php
Outdated
| } | ||
|
|
||
| $this->messageSnoozeMapper->deleteByMessageIds(array($messageId)); |
There was a problem hiding this comment.
Suggested change
| $this->messageSnoozeMapper->deleteByMessageIds(array($messageId)); | |
| $this->messageSnoozeMapper->deleteByMessageIds([$messageId]); |
Signed-off-by: Johannes Merkel <mail@johannesgge.de>
JohannesGGE
force-pushed
the
fix-snooze-index
branch
from
276dfe5 to
d7e397e
Compare
kesselb
approved these changes
Aug 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #8748
Followup to #8694
I had to rewrite the snooze db insert. Pls check if the throwing of the ServiceException is correct, I'm not quite sure.