Skip to content

Conversation

@amirmkia1997
Copy link

Summary
This pull request fixes issue #7750 which reports that calendar invitations sent from external domains (e.g., Gmail) are not properly recognized or actionable inside the Nextcloud Mail app.

Background
Users receiving calendar event invitations from outside their Nextcloud domain experienced two key problems:

Missing Tentative Event: Invitations were not automatically added to the user’s Nextcloud Calendar as tentative events, unlike invitations originating from the internal domain.

Non-functional RSVP Buttons: The “Yes”, “No”, and “Maybe” buttons embedded in external invitations were not clickable, preventing users from responding directly within the Mail app.

Proposed Changes

Improved parsing of iCalendar/ICS attachments from external domains to ensure correct detection and automatic creation of tentative events in the user’s calendar.

Fixed the handling of RSVP action links to enable immediate responses (“Yes”, “No”, “Maybe”) from within the Mail app.

Added tests to cover common external providers (e.g., Gmail, Outlook) to prevent future regressions.

Testing

Verified invitations from multiple external providers now appear as tentative events upon receipt.

Confirmed that clicking any RSVP option updates the calendar status and sends the appropriate reply to the event organizer.

Confirmed that internal invitations continue to function as before.

Notes
This change improves interoperability with external email/calendar providers and ensures a consistent experience for users managing calendar events directly from the Mail app.

@ChristophWurst
Copy link
Member

Thank you for your contribution. @amirmkia1997 is this your code? The DCO confirming that your contribution is compatible with the AGPL is missing.

await this.saveEventWithParticipationStatus(TENTATIVE)
}
} catch (e) {
// ignore auto-create failures
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Log to the console for debuggability

@github-actions
Copy link

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

@nikbinmarjan
Copy link

Please fix this bug: We need to add multiple domains as trusted domains so they automatically display in the calendar, exactly like our main domain. This is important because invitation emails can get lost among many messages in the inbox, but when events appear in the calendar, nobody misses them.

y Outdated
@@ -0,0 +1,7 @@
-----BEGIN OPENSSH PRIVATE KEY-----
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ drop this and revoke the key ASAP

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add invites to calendar automatically (tentative without respond)

3 participants