fixup! fix: normalize email addresses before using them

Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>

Author: SebastianKrupinski

lib/BackgroundJob/RepairRecipiants.php

@@ -0,0 +1,58 @@
+<?php
+
+declare(strict_types=1);
+
+/**
+ * SPDX-FileCopyrightText: 2025 Nextcloud GmbH and Nextcloud contributors
+ * SPDX-License-Identifier: AGPL-3.0-or-later
+ */
+
+namespace OCA\Mail\BackgroundJob;
+
+use OCP\AppFramework\Utility\ITimeFactory;
+use OCP\BackgroundJob\IJobList;
+use OCP\BackgroundJob\TimedJob;
+use OCP\DB\QueryBuilder\IQueryBuilder;
+use OCP\IDBConnection;
+
+class RepairRecipients extends TimedJob {
+
+	public function __construct(
+		protected ITimeFactory $time,
+		private IDBConnection $db,
+		private IJobList $jobService
+	) {
+		parent::__construct($time);
+		$this->setInterval(300);
+	}
+
+	protected function run($argument): void {
+		// fetch all quoted emails
+		$select = $this->db->getQueryBuilder();
+		$select->select('id', 'email')
+			->from('mail_recipients')
+			->where(
+				$select->expr()->like('email', $select->createNamedParameter('\'%\'', IQueryBuilder::PARAM_STR))
+			)
+			->setMaxResults(1000);
+		$recipients = $select->executeQuery()->fetchAll();
+		// update emails
+		$update = $this->db->getQueryBuilder();
+		$update->update('mail_recipients')
+			->set('email', $update->createParameter('email'), IQueryBuilder::PARAM_STR)
+			->where($update->expr()->in('id', $update->createParameter('id'), IQueryBuilder::PARAM_STR));
+		foreach ($recipients as $recipient) {
+			$id = $recipient['id'];
+			$email = $recipient['email'];
+			$email = str_replace('\'', '', $email);
+			$update->setParameter('id', $id, IQueryBuilder::PARAM_STR);
+			$update->setParameter('email', $email, IQueryBuilder::PARAM_STR);
+			$update->executeStatement();
+		}
+		// remove job depending on the result
+		if (count($recipient) === 0) {
+			$this->jobService->remove(RepairRecipients::class);
+		}
+	}
+
+}

lib/IMAP/ImapMessageFetcher.php

@@ -252,7 +252,7 @@ public function fetchMessage(?Horde_Imap_Client_Data_Fetch $fetch = null): IMAPM
 			$fetch->getFlags(),
 			AddressList::fromHorde($envelope->from, true),
 			AddressList::fromHorde($envelope->to, true),
-			AddressList::fromHorde($envelope->ccv, true),
+			AddressList::fromHorde($envelope->cc, true),
 			AddressList::fromHorde($envelope->bcc, true),
 			AddressList::fromHorde($envelope->reply_to, true),
 			$this->decodeSubject($envelope),

lib/Migration/Version5000Date20250507000000.php

@@ -0,0 +1,29 @@
+<?php
+
+declare(strict_types=1);
+
+/**
+ * SPDX-FileCopyrightText: 2024 Nextcloud GmbH and Nextcloud contributors
+ * SPDX-License-Identifier: AGPL-3.0-or-later
+ */
+
+namespace OCA\Mail\Migration;
+
+use Closure;
+use OCP\BackgroundJob\IJobList;
+use OCP\Migration\IOutput;
+use OCP\Migration\SimpleMigrationStep;
+
+class Version5000Date20250507000000 extends SimpleMigrationStep {
+
+	public function __construct(
+		private IJobList $jobService
+	) {
+		parent::__construct();
+	}
+
+	public function postSchemaChange(IOutput $output, Closure $schemaClosure, array $options) {
+		$this->jobService->add(\OCA\Mail\BackgroundJob\RepairRecipients::class);
+	}
+
+}