code cleanup #77
Merged
code cleanup #77
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blizzz
force-pushed
the
td/noid/cleanup
branch
2 times, most recently
from
5d0cf3c to
6dea0cf
Compare
- typed properties - add missing type hints and return type hints - add missing return - use match instead of switch - use str_starts_with instead of strpos - remove unused code and properties - remove duplicated condition - solve deprecations, avoid using private classes - fix jsonSerialize signature Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
|
/backport to stable26 |
Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com> Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com> Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
editing a config is currently broken on server master+26 and requires nextcloud/server#37520. Blocks a release, but not merging.
P.S.: Even not release blocking, as adding and deleting configs still works.