Merge pull request #13 from nextcloud/fix/noid/execute-int

fixes expectation that execute() returns an int

Author: ChristophWurst

lib/Command/Add.php

@@ -224,7 +224,7 @@ protected function interact(InputInterface $input, OutputInterface $output) {
 		}
 	}
 
-	protected function execute(InputInterface $input, OutputInterface $output) {
+	protected function execute(InputInterface $input, OutputInterface $output): int {
 		$config = $this->configurationService->add();
 		$config->setAddressBookDisplayName($input->getArgument('addressBookName'));
 
@@ -277,6 +277,8 @@ protected function execute(InputInterface $input, OutputInterface $output) {
 		}
 
 		$this->configurationService->update($config);
+
+		return 0;
 	}
 
 	protected function importConnection(InputInterface $input) {

lib/Command/Delete.php

@@ -51,8 +51,9 @@ protected function configure() {
 			);
 	}
 
-	protected function execute(InputInterface $input, OutputInterface $output) {
+	protected function execute(InputInterface $input, OutputInterface $output): int {
 		$id = (int)$input->getArgument('id');
 		$this->configurationService->delete($id);
+		return 0;
 	}
 }

lib/Command/Edit.php

@@ -177,7 +177,7 @@ protected function interact(InputInterface $input, OutputInterface $output) {
 
 	}
 
-	public function execute(InputInterface $input, OutputInterface $output) {
+	public function execute(InputInterface $input, OutputInterface $output): int {
 		$config = $this->configurationService->get((int)$input->getArgument('id'));
 
 		foreach ($this->getListOfOptions($config) as $optionData) {
@@ -201,6 +201,7 @@ public function execute(InputInterface $input, OutputInterface $output) {
 		}
 
 		$this->configurationService->update($config);
+		return 0;
 	}
 
 	private function yesOrNoNormalizer(string $input): ?bool {

lib/Command/ListConfigs.php

@@ -46,7 +46,7 @@ protected function configure() {
 			->setDescription('Lists all LDAP contacts backend configurations');
 	}
 
-	protected function execute(InputInterface $input, OutputInterface $output) {
+	protected function execute(InputInterface $input, OutputInterface $output): int {
 		$configs = $this->configurationService->getAll();
 		foreach ($configs as $config) {
 			/** @var ConfigurationModel $config */
@@ -59,5 +59,6 @@ protected function execute(InputInterface $input, OutputInterface $output) {
 			}
 			$this->writeMixedInOutputFormat($input, $output, $cfgValues);
 		}
+		return 0;
 	}
 }