Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add headings for slides #852

Merged
merged 2 commits into from
Jun 7, 2023
Merged

add headings for slides #852

merged 2 commits into from
Jun 7, 2023

Conversation

szaimen
Copy link
Collaborator

@szaimen szaimen commented Apr 2, 2023

Close #107

1 2 3 4
image image image image

@szaimen szaimen added this to the Nextcloud 27 milestone Apr 2, 2023
@szaimen szaimen marked this pull request as draft April 2, 2023 13:53
@skjnldsv skjnldsv modified the milestones: Nextcloud 27, Nextcloud 28 May 9, 2023
@szaimen szaimen force-pushed the enh/noid/add-headings-for-slides branch from b46e565 to 108de7b Compare May 12, 2023 11:49
@szaimen szaimen marked this pull request as ready for review May 12, 2023 12:00
@szaimen szaimen added the design label May 12, 2023
Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd say just using the position of the slogan (on the blue background above) is nicer for the header. Then we don't use more space, and the text is not just all the same on all pages.

Text I'd suggest for each slide:

  1. A safe home for your data (like now but with capital A)
  2. Extend your cloud (like the page title)
  3. Stay in sync (like the page title)
  4. Get support or participate (as you suggested)

@szaimen
Copy link
Collaborator Author

szaimen commented May 15, 2023

I'd say just using the position of the slogan (on the blue background above) is nicer for the header. Then we don't use more space, and the text is not just all the same on all pages.

I get your point but the heading is then not visually connected to the content anymore (since the header is visually separated and the slogan also directly connected to the logo instead of the content) which it should be imho... So leaving it in the main content is more easy to understand imo...

Signed-off-by: Simon L <szaimen@e.mail.de>
@szaimen szaimen force-pushed the enh/noid/add-headings-for-slides branch from 056c5fa to 348d0f0 Compare May 15, 2023 10:16
@szaimen
Copy link
Collaborator Author

szaimen commented May 15, 2023

  • Extend your cloud (like the page title)
  • Stay in sync (like the page title)
  • Get support or participate (as you suggested)

Should be adjusted

@jancborchardt
Copy link
Member

We need to get the slides simpler though. :) I think having the heading in the blue part will be fine. We can also bold it for more presence.

But adding more text makes it quite cluttered.

@szaimen
Copy link
Collaborator Author

szaimen commented May 15, 2023

all right. Let me investigate then how we could add this to the header...

@szaimen szaimen marked this pull request as draft May 15, 2023 13:59
@szaimen szaimen force-pushed the enh/noid/add-headings-for-slides branch 2 times, most recently from acf4c10 to dedc356 Compare June 1, 2023 09:36
Signed-off-by: Simon L <szaimen@e.mail.de>
@szaimen szaimen force-pushed the enh/noid/add-headings-for-slides branch from dedc356 to 04ffa01 Compare June 1, 2023 09:48
@szaimen
Copy link
Collaborator Author

szaimen commented Jun 1, 2023

@jancborchardt I investigated a bit and due to how the app is currently built: Rendering in Vue but templates in PHP, I currently don't see an good way to insert a title from the template into the header of the modal (despite hacky ways) without rewriting quite some code. (which I am not sure about how to do currently).

So would it be okay to leave it in the body for now or do we rather want to postpone this?

@szaimen szaimen marked this pull request as ready for review June 1, 2023 14:10
Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go with this for now :)

@szaimen szaimen merged commit 0ac141c into master Jun 7, 2023
@szaimen szaimen deleted the enh/noid/add-headings-for-slides branch June 7, 2023 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Relevant heading text for each slide
3 participants