Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Correctly label share via email #1337

Merged
merged 2 commits into from
Aug 29, 2024
Merged

fix: Correctly label share via email #1337

merged 2 commits into from
Aug 29, 2024

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Aug 28, 2024

There was a type so the conditional rendering was not working (and displaying "share on EMail").

before after
Screenshot 2024-08-28 at 18-46-49 Personal info - Personal settings - Nextcloud Screenshot 2024-08-28 at 18-53-32 Personal info - Personal settings - Nextcloud

Copy link
Collaborator

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but didnt test

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
Copy link
Contributor Author

susnux commented Aug 29, 2024

/compile

@susnux susnux enabled auto-merge August 29, 2024 10:59
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@susnux susnux merged commit 1546e64 into master Aug 29, 2024
40 checks passed
@susnux susnux deleted the fix/email branch August 29, 2024 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants