Merge pull request #47 from nextcloud/feat/handle-invalid-name

Author: juliusknorr

lib/Service/ZipService.php

@@ -60,11 +60,14 @@ public function __construct(IRootFolder $rootFolder, NotificationService $notifi
 		$this->jobList = $jobList;
 	}
 
-	public function createZipJob(array $fileIds, $target): void {
+	public function createZipJob(array $fileIds, string $target): void {
 		$user = $this->userSession->getUser();
 		if ($user === null) {
 			throw new Exception('No user session available');
 		}
+		if (strlen($target) === 0) {
+			throw new Exception('The target is invalid');
+		}
 		$this->jobList->add(ZipJob::class, [
 			'uid' => $user->getUID(),
 			'fileIds' => $fileIds,

src/main.js

@@ -22,9 +22,14 @@ import { showError, showSuccess } from '@nextcloud/dialogs'
 						t('files_zip', 'Select a name for the zip archive'),
 						n('files_zip', 'Compress {files} file', 'Compress {files} files', selectedFiles.length, { files: selectedFiles.length }),
 						(result, target) => {
-							if (result) {
-								this.compressFiles(selectedFiles, fileList.getCurrentDirectory() + '/' + target)
+							if (!result) {
+								return
 							}
+							if (target.length === 0) {
+								showError(t('files_zip', 'The name selected is invalid.'))
+								return
+							}
+							this.compressFiles(selectedFiles, fileList.getCurrentDirectory() + '/' + target)
 						}, true, t('files_zip', 'File name')
 					).then(this.enhancePrompt.bind(this, suggestedFilename))
 				},