Merge pull request #461 from nextcloud/backport/459/stable20

[stable20] Fix hide download and printing

Author: skjnldsv

.github/workflows/phpunit.yml

@@ -29,13 +29,7 @@ jobs:
         with:
           repository: nextcloud/server
           ref: ${{ github.base_ref }}
-
-      - name: Checkout submodules
-        shell: bash
-        run: |
-          auth_header="$(git config --local --get http.https://github.com/.extraheader)"
-          git submodule sync --recursive
-          git -c "http.extraheader=$auth_header" -c protocol.version=2 submodule update --init --force --recursive --depth=1
+          submodules: true
 
       - name: Checkout app
         uses: actions/checkout@v2
@@ -84,7 +78,7 @@ jobs:
 
     services:
       mysql:
-        image: mariadb
+        image: mariadb:10.5
         ports:
           - 4444:3306/tcp
         env:
@@ -97,13 +91,7 @@ jobs:
         with:
           repository: nextcloud/server
           ref: ${{ github.base_ref }}
-
-      - name: Checkout submodules
-        shell: bash
-        run: |
-          auth_header="$(git config --local --get http.https://github.com/.extraheader)"
-          git submodule sync --recursive
-          git -c "http.extraheader=$auth_header" -c protocol.version=2 submodule update --init --force --recursive --depth=1
+          submodules: true
 
       - name: Checkout app
         uses: actions/checkout@v2
@@ -168,13 +156,7 @@ jobs:
         with:
           repository: nextcloud/server
           ref: ${{ github.base_ref }}
-
-      - name: Checkout submodules
-        shell: bash
-        run: |
-          auth_header="$(git config --local --get http.https://github.com/.extraheader)"
-          git submodule sync --recursive
-          git -c "http.extraheader=$auth_header" -c protocol.version=2 submodule update --init --force --recursive --depth=1
+          submodules: true
 
       - name: Checkout app
         uses: actions/checkout@v2

js/files_pdfviewer-main.js

@@ -0,0 +1,6 @@
+/*!
+ * The buffer module from node.js, for the browser.
+ *
+ * @author   Feross Aboukhadijeh <feross@feross.org> <http://feross.org>
+ * @license  MIT
+ */

js/files_pdfviewer-main.js.map

@@ -38,15 +38,14 @@ window.addEventListener('DOMContentLoaded', function() {
 		const page = location.hash.split('page=')[1] || 0
 		const contentElmt = document.getElementById('files-public-content')
 		const sharingTokenElmt = document.getElementById('sharingToken')
-		const footerElmt = document.querySelector('#app-content > footer')
+		const footerElmt = document.querySelector('body > footer')
 
 		const sharingToken = sharingTokenElmt.value
 		const downloadUrl = generateUrl('/s/{token}/download', { token: sharingToken })
 		const viewerUrl = generateUrl('/apps/files_pdfviewer/?file={downloadUrl}#page={page}', { downloadUrl, page })
 
 		// Create viewer frame
 		const viewerNode = document.createElement('iframe')
-		viewerNode.src = viewerUrl
 		viewerNode.style.height = '100%'
 		viewerNode.style.width = '100%'
 		viewerNode.style.position = 'absolute'
@@ -55,10 +54,45 @@ window.addEventListener('DOMContentLoaded', function() {
 		if (contentElmt) {
 			contentElmt.innerHTML = ''
 			contentElmt.appendChild(viewerNode)
+			viewerNode.src = viewerUrl
 			footerElmt.style.display = 'none'
 		} else {
 			logger.error('Unable to inject the PDF Viewer')
 		}
+
+		// When pdf viewer is loaded
+		addEventListener('load', function() {
+			// If we forbid download, prevent interaction
+			if (!canDownload()) {
+				const pdfViewer = viewerNode.contentDocument.querySelector('.pdfViewer')
+				const PDFViewerApplication = viewerNode.contentWindow.PDFViewerApplication
+
+				if (pdfViewer) {
+					pdfViewer.classList.add('disabledTextSelection')
+				}
+
+				if (PDFViewerApplication) {
+					// Disable printing service when downloads are hidden, as even if the
+					// buttons in the UI are hidden the printing could still be triggered
+					// with Ctrl|Meta+P.
+					// Abuse the "supportsPrinting" parameter, which signals that the
+					// browser does not fully support printing, to make PDFViewer disable
+					// the printing service.
+					// "supportsPrinting" is a getter function, so it needs to be deleted
+					// before replacing it with a simple value.
+					delete PDFViewerApplication.supportsPrinting
+					PDFViewerApplication.supportsPrinting = false
+
+					// When printing is not supported a warning is shown by the default
+					// "beforePrint" function when trying to print. That function needs to
+					// be replaced with an empty one to prevent that warning to be shown.
+					PDFViewerApplication.beforePrint = function() {
+					}
+				}
+
+				logger.info('Download, printing and user interaction disabled')
+			}
+		})
 	} else {
 		logger.error('But this does not appear to be a public page')
 	}

js/files_pdfviewer-public.js

@@ -22,5 +22,4 @@
  */
 
 const hideDownloadElmt = document.getElementById('hideDownload')
-// true = hidden download
 export default () => !hideDownloadElmt || (hideDownloadElmt && hideDownloadElmt.value !== 'true')