Skip to content

Commit 8162816

Browse files
committed
Update master php testing versions
Signed-off-by: Joas Schilling <coding@schilljs.com>
1 parent a60beef commit 8162816

File tree

2 files changed

+13
-17
lines changed

2 files changed

+13
-17
lines changed

.travis.yml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
language: php
22
sudo: required
33
php:
4-
- 7.1
54
- 7.2
65
- 7.3
6+
- 7.4snapshot
77

88
services:
99
- mysql
@@ -56,13 +56,13 @@ script:
5656

5757
matrix:
5858
include:
59-
- php: 7.1
59+
- php: 7.3
6060
env: DB=mysql
61-
- php: 7.1
61+
- php: 7.3
6262
env: DB=pgsql
63-
- php: 7.1
63+
- php: 7.3
6464
env: DB=mysql;CODECHECK=1
65-
- php: 7.1
65+
- php: 7.3
6666
env: DB=mysql;CODECHECK=2
6767
fast_finish: true
6868

tests/unit/controller/displaycontrollertest.php renamed to tests/Unit/Controller/DisplayControllerTest.php

Lines changed: 8 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,9 @@
88
* See the COPYING-README file.
99
*/
1010

11-
namespace OCA\Files_PdfViewer\Controller;
11+
namespace OCA\Files_PdfViewer\Tests\Unit\Controller;
1212

13+
use OCA\Files_PdfViewer\Controller\DisplayController;
1314
use OCP\AppFramework\Http\ContentSecurityPolicy;
1415
use OCP\AppFramework\Http\TemplateResponse;
1516
use OCP\IRequest;
@@ -23,20 +24,15 @@ class DisplayControllerTest extends TestCase {
2324
private $request;
2425
/** @var IURLGenerator */
2526
private $urlGenerator;
26-
/** @var DisplayController */
27+
/** @var DisplayController
28+
*/
2729
private $controller;
2830

29-
public function setUp(){
31+
protected function setUp(): void {
3032
$this->appName = 'files_pdfviewer';
3133

32-
$this->request = $this->getMockBuilder(
33-
'\OCP\IRequest')
34-
->disableOriginalConstructor()
35-
->getMock();
36-
$this->urlGenerator = $this->getMockBuilder(
37-
'\OCP\IUrlGenerator')
38-
->disableOriginalConstructor()
39-
->getMock();
34+
$this->request = $this->createMock(IRequest::class);
35+
$this->urlGenerator = $this->createMock(IURLGenerator::class);
4036
$this->controller = new DisplayController(
4137
$this->appName,
4238
$this->request,
@@ -46,7 +42,7 @@ public function setUp(){
4642
parent::setUp();
4743
}
4844

49-
public function testShowPdfViewer() {
45+
public function testShowPdfViewer(): void {
5046
$params = [
5147
'urlGenerator' => $this->urlGenerator,
5248
'minmode' => false

0 commit comments

Comments
 (0)