Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(dev): remove deprecated createEventSource #10479

Merged
merged 1 commit into from
Jun 5, 2023
Merged

docs(dev): remove deprecated createEventSource #10479

merged 1 commit into from
Jun 5, 2023

Conversation

kesselb
Copy link
Contributor

@kesselb kesselb commented May 26, 2023 •
edited
Loading

@kesselb kesselb mentioned this pull request May 26, 2023
Merged
5 tasks
@kesselb kesselb force-pushed the chore-remove-create-event-source branch from 4a32962 to 4c3b046 Compare May 26, 2023 16:46
@kesselb kesselb mentioned this pull request May 26, 2023
Merged
2 tasks
@kesselb kesselb force-pushed the chore-remove-create-event-source branch 3 times, most recently from ab2f9c6 to 834d04f Compare June 1, 2023 16:08
ChristophWurst
ChristophWurst reviewed Jun 1, 2023
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we have a dedicated page for event source and how it's used in an app? 🙏

@kesselb
Copy link
Contributor Author

kesselb commented Jun 1, 2023

Could we have a dedicated page for event source and how it's used in an app?

I think we should review the current implementation first, as the code is ancient.

To inject IRequest into OC_EventSource was actually a side project for nextcloud/server#38445.
I did not expect to end up with EventSourceFactory ;)

@kesselb
docs(dev): remove deprecated createEventSource
5ea4697 
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
@kesselb kesselb force-pushed the chore-remove-create-event-source branch from 834d04f to 5ea4697 Compare June 5, 2023 16:30
@kesselb kesselb self-assigned this Jun 5, 2023
@kesselb kesselb merged commit 5064579 into master Jun 5, 2023
@kesselb kesselb deleted the chore-remove-create-event-source branch June 5, 2023 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristophWurst ChristophWurst ChristophWurst approved these changes

Assignees

@kesselb kesselb

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kesselb @ChristophWurst