fix: prevent E2EE metadata rollback#9426
Open
Yaroslav98214 wants to merge 1 commit intonextcloud:masterfrom
Open
fix: prevent E2EE metadata rollback#9426Yaroslav98214 wants to merge 1 commit intonextcloud:masterfrom
Yaroslav98214 wants to merge 1 commit intonextcloud:masterfrom
Conversation
Persist counters and key checksums so clients can reject downgraded metadata. Signed-off-by: Yaroslav98214 <diakovichyaroslav30@gmail.com>
Yaroslav98214
requested review from
Aiiaiiio,
camilasan,
i2h3,
mgallien and
nilsding
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: Validate E2EE metadata counter and keyChecksums; persist values in journal; add regression tests.
Tests: Not run (requires KF6Archive + Qt 6.8+).