try different permutation to try to recover the broken checksum #5572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/backport to stable-3.8 |
8 tasks
claucambra
approved these changes
Apr 4, 2023
|
Some comments would be nice to explain the bug and the ensuing fix |
camilasan
requested changes
Apr 4, 2023
mgallien
force-pushed
the
bugfix/tryHardToRecoverBrokenE2eeChecksums
branch
from
7c813c3
to
b8679cf
Compare
will only accept a checksum that can be computed from proper data should still be safe Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
mgallien
force-pushed
the
bugfix/tryHardToRecoverBrokenE2eeChecksums
branch
from
b8679cf
to
b0c6948
Compare
camilasan
approved these changes
Apr 4, 2023
|
AppImage file: nextcloud-PR-5572-b0c69481f2f457d88389b70ad511ba356f03b9bb-x86_64.AppImage |
|
I tried this, first looked good, but then it downloaded some random files (that were already local) and after that marked some of this files with the same error #5564 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
will only accept a checksum that can be computed from proper data
should still be safe