Modernize the Dolphin action plugin #5192
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #5192 +/- ##
==========================================
- Coverage 57.80% 57.71% -0.10%
==========================================
Files 138 138
Lines 17441 17441
==========================================
- Hits 10082 10066 -16
- Misses 7359 7375 +16
|
|
/rebase |
nextcloud-command
force-pushed
the
modernize-dolphin-plugin
branch
from
929be6a
to
23746ed
Compare
|
I think the SonarCloud analysis does not fail because of the patch, or am I missing something? What can be done to get the PR merged? @claucambra could you help with this? |
Seems like SonarCloud is failing for some other reason, unrelated to your changes |
Instead of installing a .desktop file, it is now converted to JSON and compiled into the plugin itself. The plugin is also installed into a different directory. Signed-off-by: István Váradi <ivaradi@varadiistvan.hu>
claucambra
force-pushed
the
modernize-dolphin-plugin
branch
from
23746ed
to
2002c98
Compare
|
AppImage file: nextcloud-PR-5192-2002c98b682bd73e2149cce341dceac4813b6d18-x86_64.AppImage |
this is due to the token being a private secret only available for jobs from branch of the main repository and not clone |
|
/backport to stable-3.6 |
|
The backport to stable-3.6 failed. Please do this backport manually. |
Instead of installing a .desktop file, it is now converted to JSON and compiled into the plugin itself. The plugin is also installed into a different directory.
As described in #4425, Dolphin complains about the .desktop file indicating that is an outdated solution. This PR moves the plugin to the recommended JSON-based solution.