-
Notifications
You must be signed in to change notification settings - Fork 275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement new dashboard widget interfaces #4033
Merged
juliushaertl
merged 5 commits into
master
from
enh/4032/implement-new-dashboard-widget-interfaces
Sep 21, 2022
Merged
Implement new dashboard widget interfaces #4033
juliushaertl
merged 5 commits into
master
from
enh/4032/implement-new-dashboard-widget-interfaces
Sep 21, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
julien-nc
force-pushed
the
enh/4032/implement-new-dashboard-widget-interfaces
branch
2 times, most recently
from
September 16, 2022 11:48
d83a570
to
acbde3f
Compare
Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
julien-nc
force-pushed
the
enh/4032/implement-new-dashboard-widget-interfaces
branch
from
September 16, 2022 11:52
acbde3f
to
6449082
Compare
Rebased on master. |
tobiasKaminsky
approved these changes
Sep 19, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and works from client side 👍
juliushaertl
approved these changes
Sep 21, 2022
juliushaertl
deleted the
enh/4032/implement-new-dashboard-widget-interfaces
branch
September 21, 2022 16:40
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
requires nextcloud/server#33658
closes #4032
closes #4034
Implement IAPIWidget, IButtonWidget and IIconWidget to provide information to clients.
Also make a small change in the dashboard widget component. It can be removed it if it's too much out of scope.