Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement new dashboard widget interfaces #4033

Merged

Conversation

julien-nc
Copy link
Member

@julien-nc julien-nc commented Sep 6, 2022

requires nextcloud/server#33658
closes #4032
closes #4034

Implement IAPIWidget, IButtonWidget and IIconWidget to provide information to clients.

Also make a small change in the dashboard widget component. It can be removed it if it's too much out of scope.

Julien Veyssier added 4 commits September 16, 2022 13:32
Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
@julien-nc julien-nc force-pushed the enh/4032/implement-new-dashboard-widget-interfaces branch 2 times, most recently from d83a570 to acbde3f Compare September 16, 2022 11:48
Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
@julien-nc julien-nc force-pushed the enh/4032/implement-new-dashboard-widget-interfaces branch from acbde3f to 6449082 Compare September 16, 2022 11:52
@julien-nc
Copy link
Member Author

Rebased on master.
We can ignore the Psalm complaints as I don't know how to remove them but can assure it works 😁.

Copy link
Member

@tobiasKaminsky tobiasKaminsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works from client side 👍

@juliushaertl juliushaertl merged commit f9836d4 into master Sep 21, 2022
@juliushaertl juliushaertl deleted the enh/4032/implement-new-dashboard-widget-interfaces branch September 21, 2022 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adapt upcoming cards dashboard widget for mobile clients Implement IButtonWidget and IIconWidget interfaces
3 participants