Skip to content

[stable7.0] fix: Instantiation of ContactsManager #4399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 19, 2025
Merged

[stable7.0] fix: Instantiation of ContactsManager #4399

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions lib/Service/SocialApiService.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@

use OCA\DAV\CardDAV\CardDavBackend;
use OCA\DAV\CardDAV\ContactsManager;

use OCA\DAV\Db\PropertyMapper;
use OCP\AppFramework\Http;
use OCP\AppFramework\Http\JSONResponse;
use OCP\AppFramework\Utility\ITimeFactory;
Expand All @@ -38,6 +38,7 @@
private CardDavBackend $davBackend,
private ITimeFactory $timeFactory,
private ImageResizer $imageResizer,
private PropertyMapper $propertyMapper,
) {
$this->appName = Application::APP_ID;
}
Expand Down Expand Up @@ -115,7 +116,7 @@
* @param {IManager} the contact manager to load
*/
protected function registerAddressbooks($userId, IManager $manager) {
$coma = new ContactsManager($this->davBackend, $this->l10n);
$coma = new ContactsManager($this->davBackend, $this->l10n, $this->propertyMapper);
$coma->setupContactsProvider($manager, $userId, $this->urlGen);
$this->manager = $manager;
}
Expand Down Expand Up @@ -227,7 +228,7 @@
*/
public function existsAddressBook(string $searchBookId, string $userId): bool {
$manager = $this->manager;
$coma = new ContactsManager($this->davBackend, $this->l10n);
$coma = new ContactsManager($this->davBackend, $this->l10n, $this->propertyMapper);

Check warning on line 231 in lib/Service/SocialApiService.php

View check run for this annotation

Codecov / codecov/patch

lib/Service/SocialApiService.php#L231 

Added line #L231 was not covered by tests
$coma->setupContactsProvider($manager, $userId, $this->urlGen);
$addressBooks = $manager->getUserAddressBooks();
return $this->getAddressBook($searchBookId, $manager) !== null;
Expand All @@ -245,7 +246,7 @@
public function existsContact(string $searchContactId, string $searchBookId, string $userId): bool {
// load address books for the user
$manager = $this->manager;
$coma = new ContactsManager($this->davBackend, $this->l10n);
$coma = new ContactsManager($this->davBackend, $this->l10n, $this->propertyMapper);
$coma->setupContactsProvider($manager, $userId, $this->urlGen);
$addressBook = $this->getAddressBook($searchBookId, $manager);
if ($addressBook == null) {
Expand Down
25 changes: 15 additions & 10 deletions tests/unit/Service/SocialApiServiceTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@

use OCA\Contacts\Service\Social\ISocialProvider;
use OCA\DAV\CardDAV\CardDavBackend;
use OCA\DAV\Db\PropertyMapper;
use OCP\AppFramework\Http;
use OCP\AppFramework\Utility\ITimeFactory;
use OCP\Contacts\IManager;
Expand All @@ -29,24 +30,26 @@
class SocialApiServiceTest extends TestCase {
private SocialApiService $service;

/** @var CompositeSocialProvider|MockObject */
/** @var CompositeSocialProvider&MockObject */
private $socialProvider;
/** @var IManager|MockObject */
/** @var IManager&MockObject */
private $manager;
/** @var IConfig|MockObject */
/** @var IConfig&MockObject */
private $config;
/** @var IClientService|MockObject */
/** @var IClientService&MockObject */
private $clientService;
/** @var IL10N|MockObject */
/** @var IL10N&MockObject */
private $l10n;
/** @var IURLGenerator|MockObject */
/** @var IURLGenerator&MockObject */
private $urlGen;
/** @var CardDavBackend|MockObject */
/** @var CardDavBackend&MockObject */
private $davBackend;
/** @var ITimeFactory|MockObject */
/** @var ITimeFactory&MockObject */
private $timeFactory;
/** @var ImageResizer|MockObject */
/** @var ImageResizer&MockObject */
private $imageResizer;
/** @var PropertyMapper&MockObject */
private $propertyMapper;

public function allSocialProfileProviders(): array {
$body = 'the body';
Expand Down Expand Up @@ -113,6 +116,7 @@ protected function setUp(): void {
$this->davBackend = $this->createMock(CardDavBackend::class);
$this->timeFactory = $this->createMock(ITimeFactory::class);
$this->imageResizer = $this->createMock(ImageResizer::class);
$this->propertyMapper = $this->createMock(PropertyMapper::class);
$this->service = new SocialApiService(
$this->socialProvider,
$this->manager,
Expand All @@ -122,7 +126,8 @@ protected function setUp(): void {
$this->urlGen,
$this->davBackend,
$this->timeFactory,
$this->imageResizer
$this->imageResizer,
$this->propertyMapper,
);
}

Expand Down