Enable binary_operator_spaces #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
|
So how do we do things like this? always bump the major? |
Excellent question. I'm not sure. Breaking change would mean that the API the lib exposes changes, right? And then it becomes a bit unclear if a change like this is a breaking one or not. Yes, the code needs to be formatted differently, but we use the lib the same way. Other linting libs like https://github.com/vuejs/eslint-plugin-vue/releases have a sane SEMVER but they expose just the rules. We enforce all of them by default. I think I'll just try to get a set of changes in and then do a major bump. But I'm not sure how to handle individual changes like this one if this was to be released ASAP. |
delete-merged-branch
bot
deleted the
enhancement/binary_operator_spaces
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docs at https://github.com/FriendsOfPhp/PHP-CS-Fixer.
This is also used by Symfony.
I like it because it gives consistency.
Demo: nextcloud/server#23189