Skip to content

Conversation

@ArtificialOwl
Copy link
Member

No description provided.

@ArtificialOwl ArtificialOwl force-pushed the fix/noid/share-with-group-members-only branch 2 times, most recently from 6b4d492 to 6dd5c8e Compare January 6, 2022 17:31
Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks ok, not sure if this is still a draft?

$event = new FederatedEvent(SingleMemberAdd::class);
$event->setCircle($circle);
$event->setMember($member);
$event->getParams()->sBool('force_group_member', true);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is sBool the equivalent of setBool ?

continue;
}

echo 'NO NON ' . json_encode($circle) . "\n";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stray debugging stuff?

Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
@ArtificialOwl ArtificialOwl force-pushed the fix/noid/share-with-group-members-only branch from 6dd5c8e to 402e0ac Compare April 12, 2022 21:55
@codecov-commenter
Copy link

Codecov Report

Merging #891 (484ea1d) into master (c650524) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

❗ Current head 484ea1d differs from pull request most recent head 402e0ac. Consider uploading reports for the commit 402e0ac to get more accurate results

@@             Coverage Diff             @@
##             master    #891      +/-   ##
===========================================
- Coverage      0.70%   0.69%   -0.01%     
- Complexity     5735    5777      +42     
===========================================
  Files           290     290              
  Lines         19822   19940     +118     
===========================================
  Hits            139     139              
- Misses        19683   19801     +118     
Impacted Files Coverage Δ
lib/Db/CoreQueryBuilder.php 0.00% <0.00%> (ø)
lib/Db/MembershipRequest.php 0.00% <0.00%> (ø)
lib/FederatedItems/CircleJoin.php 0.00% <0.00%> (ø)
lib/FederatedItems/SingleMemberAdd.php 0.00% <0.00%> (ø)
lib/Model/Circle.php 20.86% <0.00%> (ø)
lib/Model/Federated/FederatedEvent.php 0.00% <ø> (ø)
lib/Model/FederatedUser.php 0.00% <0.00%> (ø)
lib/Model/Member.php 0.00% <0.00%> (ø)
lib/Model/Membership.php 0.00% <0.00%> (ø)
lib/Model/ModelManager.php 1.92% <0.00%> (-0.21%) ⬇️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c650524...402e0ac. Read the comment docs.

@blizzz blizzz added this to the Nextcloud 30 milestone Apr 11, 2024
@skjnldsv skjnldsv mentioned this pull request Aug 22, 2024
44 tasks
@blizzz blizzz modified the milestones: Nextcloud 30, Nextcloud 31 Sep 4, 2024
@blizzz blizzz mentioned this pull request Jan 29, 2025
1 task
@blizzz blizzz modified the milestones: Nextcloud 31, Nextcloud 32 Jan 29, 2025
@skjnldsv skjnldsv modified the milestones: Nextcloud 32, Nextcloud 33 Sep 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants