[stable31] fix(federated-teams): ignore duplicate instance and generate logs

lib/Db/EventWrapperRequest.php

@@ -11,8 +11,8 @@
 
 namespace OCA\Circles\Db;
 
+use Doctrine\DBAL\Exception\UniqueConstraintViolationException;
 use OCA\Circles\Model\Federated\EventWrapper;
-use OCP\DB\Exception;
 use Psr\Log\LoggerInterface;
 
 /**
@@ -42,7 +42,7 @@ public function save(EventWrapper $wrapper): void {
 
 		try {
 			$qb->execute();
-		} catch (Exception $e) {
+		} catch (UniqueConstraintViolationException $e) {
 			$logger = \OCP\Server::get(LoggerInterface::class);
 			$logger->warning('issue while storing event', ['exception' => $e]);
 		}

lib/Service/FederatedEventService.php

@@ -395,19 +395,27 @@ public function initBroadcast(FederatedEvent $event): bool {
 		$wrapper->setCreation(time());
 		$wrapper->setSeverity($event->getSeverity());
 
+		$avoidDuplicate = [];
 		if ($event->isAsync()) {
 			$wrapper->setInstance($this->configService->getLoopbackInstance());
 			$this->eventWrapperRequest->save($wrapper);
+			$avoidDuplicate[] = $this->configService->getLoopbackInstance();
 		}
 
 		foreach ($instances as $instance) {
 			if ($event->getCircle()->isConfig(Circle::CFG_LOCAL)) {
 				break;
 			}
 
+			if (in_array($instance->getInstance(), $avoidDuplicate, true)) {
+				Server::get(\Psr\Log\LoggerInterface::class)->warning('duplicate instance, please verify the setup of Federated Teams', ['duplicate' => $avoidDuplicate, 'loopback' => $this->configService->getLoopbackInstance(), 'instance' => $instance->getInstance(), 'interface' => $instance->getInterface()]);
+				continue;
+			}
+
 			$wrapper->setInstance($instance->getInstance());
 			$wrapper->setInterface($instance->getInterface());
 			$this->eventWrapperRequest->save($wrapper);
+			$avoidDuplicate[] = $wrapper->getInstance();
 		}
 
 		$request = new NCRequest('', Request::TYPE_POST);